9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] stopgap for vlong bug
Date: Tue, 15 Sep 2009 17:20:36 -0400	[thread overview]
Message-ID: <d84403de694e4cb39d58012aad2f033f@quanstro.net> (raw)

reported here http://9fans.net/narchive/2009/08/1042

i haven't had much time to even look at this problem.  this
will at least abort the compile, rather than miscompile.  so
it's marginally better than nothing.

the warning is just documentation of the problem.  i recompiled
everything with this patch and didn't see it trip (except in
my lucky code), so i wonder if there is always a problem if
t->right->reg != D_DX holds.

/n/sources/plan9//sys/src/cmd/8c/cgen64.c:2293,2298 - cgen64.c:2293,2300
  					evacaxdx(l);
  				}
  			}
+ 			if(l->op == OSUB && l->right != Z && l->right->op == OCAST)
+ 				warn(n, "likely vlong bug");
  			t = regpair(Z, n);
  			sugen(r, t, 8);
  			r = t;
/n/sources/plan9//sys/src/cmd/8c/cgen64.c:2336,2341 - cgen64.c:2338,2344
  			zapreg(t->left);
  		}
  		if(t->right->reg != D_DX) {
+ 			fatal(Z, "vlong double-spill botch");
  			d = &nod4;
  			regsalloc(d, t->right);
  			gmove(&nod2, d);

- erik



                 reply	other threads:[~2009-09-15 21:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84403de694e4cb39d58012aad2f033f@quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).