[9fans] bugs in test command

[9fans] bugs in test command

[lawler.jack]

I updated my system today and had trouble with
the usbfat:, 9fat:, and pull scripts because of errors
by the new test command.

	term% ls /dev/kfs.cmd
	ls: /dev/kfs.cmd: '/dev/kfs.cmd' file does not exist
	term% test -f /dev/kfs.cmd
	term% echo $status

	term%


Thank you.

Re: [9fans] bugs in test command

[Charles Forsyth]

i could not see why the code was changed.
there's a long comment added to explain that the
strings aren't copied, but the old code also didn't use
the strings (and set them to nil) for that reason.
perhaps my mechanical search for uses missed one.

Re: [9fans] bugs in test command

[erik quanstrom]

> I updated my system today and had trouble with
> the usbfat:, 9fat:, and pull scripts because of errors
> by the new test command.
>
> 	term% ls /dev/kfs.cmd
> 	ls: /dev/kfs.cmd: '/dev/kfs.cmd' file does not exist
> 	term% test -f /dev/kfs.cmd
> 	term% echo $status
>
> 	term%
>
>
> Thank you.

	; 9fs sources
	; cp /n/sources/plan9/sys/src/cmd/test.c .
	; 8c test.c
	; 8l -o test test.c
	; ./test -f /dev/kfs.cmd;echo $status
	test 5551: false

not the change in test.

	; bind /n/sources/plan9/386/lib /386/lib
	; 8l -o test test.8
	; ./test -f /dev/kfs.cmd;echo $status
	test 5589: false

not a library change

	; /n/sources/plan9/386/bin/8c test.c
	; /n/sources/plan9/386/bin/8l -o test test.8
	; ./test -f /dev/kfs.cmd;echo $status
	test 5596: false

not the compiler.

	; /n/sources/plan9/386/bin/test -f /dev/kfs.cmd
	; echo $status


but the executable does appear to be broken anyway.

if you recompile test, things should start working again.

- erik