* [9fans] replica/applylog reports "a" for deletions
@ 2010-07-06 10:21 yaroslav
2010-07-06 10:28 ` erik quanstrom
0 siblings, 1 reply; 6+ messages in thread
From: yaroslav @ 2010-07-06 10:21 UTC (permalink / raw)
To: 9fans
Is there a particular reason for replica/applylog to masquerade file
deletions as additions? Or that's just a typo?
/sys/src/cmd/replica/applylog.c:/^main/+159
- yaroslav
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [9fans] replica/applylog reports "a" for deletions
2010-07-06 10:21 [9fans] replica/applylog reports "a" for deletions yaroslav
@ 2010-07-06 10:28 ` erik quanstrom
2010-07-06 10:41 ` yaroslav
0 siblings, 1 reply; 6+ messages in thread
From: erik quanstrom @ 2010-07-06 10:28 UTC (permalink / raw)
To: 9fans
> Is there a particular reason for replica/applylog to masquerade file
> deletions as additions? Or that's just a typo?
i'm pretty sure this code does remove files.
DoRemove:
USED(checkedmatch1);
assert(ismatch(name));
chat("a %q %luo %q %q %lud\n", name, rd.mode, rd.uid, rd.gid, rd.mtime);
if(donothing)
break;
>> if(remove(local) < 0){
error("removing %q: %r", name);
skip = 1;
continue;
}
- erik
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [9fans] replica/applylog reports "a" for deletions
2010-07-06 10:28 ` erik quanstrom
@ 2010-07-06 10:41 ` yaroslav
2010-07-06 10:45 ` erik quanstrom
0 siblings, 1 reply; 6+ messages in thread
From: yaroslav @ 2010-07-06 10:41 UTC (permalink / raw)
To: 9fans
>> Is there a particular reason for replica/applylog to masquerade file
>> deletions as additions? Or that's just a typo?
>
> i'm pretty sure this code does remove files.
no doubts about what it does, but rather what it says to the user:
…
DoRemove:
USED(checkedmatch1);
assert(ismatch(name));
chat("a %q %luo %q %q %lud\n", name, rd.mode, rd.uid, rd.gid, rd.mtime);
…
I guess there should be chat("d %q %luo %q %q %lud\n", …) instead.
Or do I miss something?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-06 18:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-06 10:21 [9fans] replica/applylog reports "a" for deletions yaroslav
2010-07-06 10:28 ` erik quanstrom
2010-07-06 10:41 ` yaroslav
2010-07-06 10:45 ` erik quanstrom
2010-07-06 10:58 ` yaroslav
2010-07-06 18:34 ` Yaroslav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).