From: Russ Cox <rsc@swtch.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: Re: [9fans] Kernel crash bug
Date: Sat, 1 Aug 2009 16:09:30 -0700 [thread overview]
Message-ID: <dd6fe68a0908011609l2fc12b6by278d132cdcb671f4@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64-044.0908011839420.12216@unix10.andrew.cmu.edu>
validname0 looks like it is trying to be too clever.
A better version of the first if statement would be:
if((ulong)name < KZERO) {
validaddr((ulong)name, 1, 0);
if(!dup)
print("warning: validname called from %lux with user pointer", pc);
ename = vmemchr(name, 0, 1<<16);
} else
ename = memchr(name, 0, 1<<16);
Russ
next prev parent reply other threads:[~2009-08-01 23:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 21:01 Elizabeth Jones
2009-08-01 21:37 ` cinap_lenrek
2009-08-01 22:01 ` Charles Forsyth
2009-08-01 22:08 ` Russ Cox
2009-08-01 22:47 ` Elizabeth Jones
2009-08-01 23:09 ` Russ Cox [this message]
2009-08-01 23:15 ` cinap_lenrek
2009-08-02 1:38 ` erik quanstrom
2009-08-02 2:13 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6fe68a0908011609l2fc12b6by278d132cdcb671f4@mail.gmail.com \
--to=rsc@swtch.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).