From mboxrd@z Thu Jan  1 00:00:00 1970
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.64-044.0908011839420.12216@unix10.andrew.cmu.edu>
References: <335ad4871879ca38a650196a26e6f200@gmx.de>
	 <acfe2c8ff2577b95456cb02b1af3e6ef@terzarima.net>
	 <dd6fe68a0908011508u64d7a7cbobc4c60fcd48d0769@mail.gmail.com>
	 <Pine.LNX.4.64-044.0908011839420.12216@unix10.andrew.cmu.edu>
Date: Sat,  1 Aug 2009 16:09:30 -0700
Message-ID: <dd6fe68a0908011609l2fc12b6by278d132cdcb671f4@mail.gmail.com>
Subject: Re: [9fans] Kernel crash bug
From: Russ Cox <rsc@swtch.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Topicbox-Message-UUID: 350de6d0-ead5-11e9-9d60-3106f5b1d025

validname0 looks like it is trying to be too clever.
A better version of the first if statement would be:

	if((ulong)name < KZERO) {
		validaddr((ulong)name, 1, 0);
		if(!dup)
			print("warning: validname called from %lux with user pointer", pc);
		ename = vmemchr(name, 0, 1<<16);
	} else
		ename = memchr(name, 0, 1<<16);

Russ