From: Russ Cox <rsc@swtch.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: Re: [9fans] bind vs. 9660srv
Date: Mon, 10 Aug 2009 11:50:00 -0700 [thread overview]
Message-ID: <dd6fe68a0908101150i52b92319y4c4acd287ea065f9@mail.gmail.com> (raw)
In-Reply-To: <b79747af76a853d89d5f881c07039fa5@quanstro.net>
On Mon, Aug 10, 2009 at 11:27 AM, erik quanstrom<quanstro@quanstro.net> wrote:
>> but should say (untested)
>
> s/un(tested)/\1
>
>> No one noticed before because most 9P2000 servers
>> assume they are being used correctly and implement
>> a simpler check: if offset == 0, seek to beginning,
>> otherwise continue where the last read left off.
>
> ken fs does so i'm still a bit puzzled.
Not the code I'm looking at
(/sys/src/cmd/cwfs/9p2.c)
start += n;
if(start < offset)
continue;
if(count < n){
putbuf(p1);
goto out1;
}
There's no check that you get
to start == offset before copying data in.
So if you passed in an offset that was
off by a few bytes, it would get rounded
to a real directory entry boundary.
Russ
next prev parent reply other threads:[~2009-08-10 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 14:41 erik quanstrom
2009-08-10 17:29 ` Russ Cox
2009-08-10 18:27 ` erik quanstrom
2009-08-10 18:50 ` Russ Cox [this message]
2009-08-10 18:57 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6fe68a0908101150i52b92319y4c4acd287ea065f9@mail.gmail.com \
--to=rsc@swtch.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).