From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 In-Reply-To: <95eeae8abc004db7fa81fe6198a64060@quanstro.net> References: <95eeae8abc004db7fa81fe6198a64060@quanstro.net> Date: Wed, 18 Mar 2009 13:52:36 +0000 Message-ID: From: roger peppe To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [9fans] Strange rc bug for the 9fans bug-squashing squad Topicbox-Message-UUID: be4f6a0a-ead4-11e9-9d60-3106f5b1d025 2009/3/18 erik quanstrom : > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ewd =3D wd+l+100-1; one small comment, based on a totally superficial scan of that diff: might it not be better to grow the buffer by some multiplicative factor, to avoid linear behaviour when reading large files? i often (for no particularly good reason) use 50% as a growth factor - it doesn't seem as radical as *2, but will still work ok in the long run. i've probably misread the code though...