Re: [9fans] dns

[erik quanstrom <quanstro@quanstro.net>]

On Wed Aug 22 08:38:51 EDT 2012, cinap_lenrek@gmx.de wrote:
> look closely at:
>
> > 		qp->curdest = &qp->dest[j];
>
> this just takes the address, it doesnt actually dereference anything. you
> could write this as qp->curdest = qp->dest + j.
>
> that destck(qp->curdest); call and the j >= Maxdest check after the
> serveraddrs() call seem like a confused debug attempt to me. or is here
> any reason why serveraddrs() should *not* fill the whole array up
> to the last element and stop at Maxdest-2?

it will stop at setting qp->curdest = &qp->dest[Maxdest-1],
since the maximum return value is the loop limit + 1.

since qb->curdest is indirected, for example by setdestoutns, this must be
a valid pointer to remain safe.

and further, after failing to get an answer from 24 different servers, it's unlikely
that the 25th will trying 24 different servers for the same address is already
i think it should be smaller.  but that's just me.  :-).

i think we can all agree that this code is hard to read.

- erik