9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] /n/sources/patch/tlsbuffer
Date: Tue,  8 Jan 2013 18:15:23 -0500	[thread overview]
Message-ID: <e682a855d744af5ecb58f7631683e44f@kw.quanstro.net> (raw)

the buffer isn't big enough for SHA1 hashes, which are larger than MD5
hashes.

- erik

; 9diff devtls.c
/n/sources/plan9/sys/src/9/port/devtls.c:732,738 - devtls.c:732,738
  {
  	OneWay *volatile in;
  	Block *volatile b;
- 	uchar *p, seq[8], header[RecHdrLen], hmac[MD5dlen];
+ 	uchar *p, seq[8], header[RecHdrLen], hmac[MaxMacLen];
  	int volatile nconsumed;
  	int len, type, ver, unpad_len;

/n/sources/plan9/sys/src/9/port/devtls.c:1323,1329 - devtls.c:1323,1329

  	tr = tlsdevs[CONV(c->qid)];
  	if(tr == nil)
- 		panic("tlsbread");
+ 		panic("tlsbwrite");

  	ty = TYPE(c->qid);
  	switch(ty) {



                 reply	other threads:[~2013-01-08 23:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e682a855d744af5ecb58f7631683e44f@kw.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).