9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: cinap_lenrek@gmx.de
To: 9fans@9fans.net
Subject: Re: [9fans] lock diagnostics on Fossil server
Date: Tue, 26 Oct 2010 04:01:52 +0200	[thread overview]
Message-ID: <e6955ff428124877861dddfe0be6fd6e@gmx.de> (raw)
In-Reply-To: <6701519c3b154bfb8462542b787fbae5@coraid.com>

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]

hm... wouldnt it just crash if mh->mount is nil?

--
cinap

[-- Attachment #2: Type: message/rfc822, Size: 2860 bytes --]

From: erik quanstrom <quanstro@labs.coraid.com>
To: lucio@proxima.alt.za, 9fans@9fans.net
Subject: Re: [9fans] lock diagnostics on Fossil server
Date: Mon, 25 Oct 2010 09:20:51 -0400
Message-ID: <6701519c3b154bfb8462542b787fbae5@coraid.com>

> I had a couple of CPU sessions running on it.  The most obvious trigger
> seems to have been exportfs, I eventually turned off the stats report

sounds familiar.  this patch needs to be applied to the kernel:

/n/sources/plan9//sys/src/9/port/chan.c:1012,1018 - chan.c:1012,1020
  				/*
  				 * mh->mount->to == c, so start at mh->mount->next
  				 */
+ 				f = nil;
  				rlock(&mh->lock);
+ 				if(mh->mount)
  				for(f = mh->mount->next; f; f = f->next)
  					if((wq = ewalk(f->to, nil, names+nhave, ntry)) != nil)
  						break;

please apply.  if the problem persists after the fix, use acid to print the
source of the pcs and qpcs of the procs involved and send that offline.

- erik

  parent reply	other threads:[~2010-10-26  2:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-24 12:20 Lucio De Re
2010-10-25 13:20 ` erik quanstrom
2010-10-25 14:35   ` Lucio De Re
2010-10-26  2:01   ` cinap_lenrek [this message]
2010-10-26 12:44     ` erik quanstrom
2010-10-26 13:45       ` Lucio De Re
2010-10-26 14:31         ` erik quanstrom
2010-10-26 14:28   ` Russ Cox
2010-10-26 14:48     ` erik quanstrom
2010-10-26 16:27     ` Lucio De Re
2010-10-26 17:01       ` erik quanstrom
2010-10-27  3:03         ` lucio
2010-10-27  4:14           ` erik quanstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6955ff428124877861dddfe0be6fd6e@gmx.de \
    --to=cinap_lenrek@gmx.de \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).