From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: Date: Tue, 12 Apr 2005 21:27:23 -0400 From: Russ Cox To: Fans of the OS Plan 9 from Bell Labs <9fans@cse.psu.edu> Subject: Re: [9fans] /sys/src/fs/port/auth.c In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: Topicbox-Message-UUID: 370df600-ead0-11e9-9d60-3106f5b1d025 the OK is for synchronization. having a fixed-size message at the end=20 makes it easy for both sides to agree on when p9any stops and the p9sk1 protocol begins. russ On 4/12/05, Tim Newsham wrote: > Around /sys/src/fs/port/auth.c:312 a ticket request is sent > to the client without first sending the tr.type field to > AuthTreq. This violates the protocol as documented in > authsrv(6). I would submit a patch but I dont run my own > kenfs and cant validate the fix. >=20 > I'm suprised this is tolerated, doesn't the 9p client check > this field for validity? The auth server will not honor > the ticket request if it is passed on without first filling > in this field. >=20 > Semi-related question: why is the p9sk1 protocol slightly different > in /sys/src/fs (ie. "v.2 p9sk1@...\0", and "OK\0")? >=20 > Tim Newsham > http://www.lava.net/~newsham/ >