[9fans] deleting files?

[9fans] deleting files?

[ISHWAR RATTAN]

Here is another silly one.

Student created a file (ls -l output)

a--------- M  48 user user ... H[?]test1.c

and rm complains that
rm : can't stat 'H[?]test1.c': no file or dir entry

I understand that [?] is a control char in filename.
Is there a way to delete it?

-ishwar

Re: [9fans] deleting files?

[Russ Cox]

> Student created a file (ls -l output)
>
> a--------- M  48 user user ... H[?]test1.c

I assume rm H*test1.c does not work?

Can you send the output of

ls | grep H.*test1.c | xd -b -c

Thanks.
Russ

Re: [9fans] deleting files?

[ISHWAR RATTAN]

   The out put of

ls | grep H.*test1.c | xd -b -c
   is

0000000  48 ef bf bd 74 65 73 74 31 2e 63 0a
       0   H ef bf bd  t  e  s  t  1  .  c \n
000000c

-ishwar

On Thu, 22 Sep 2005, Russ Cox wrote:

>> Student created a file (ls -l output)
>>
>> a--------- M  48 user user ... H[?]test1.c
>
> I assume rm H*test1.c does not work?
>
> Can you send the output of
>
> ls | grep H.*test1.c | xd -b -c
>
> Thanks.
> Russ
>

Re: [9fans] deleting files?

[Russ Cox]

>    The out put of
>
> ls | grep H.*test1.c | xd -b -c
>    is
>
> 0000000  48 ef bf bd 74 65 73 74 31 2e 63 0a
>        0   H ef bf bd  t  e  s  t  1  .  c \n
> 000000c

Bad UTF got into the file system some how,
and so ls is showing you an FFFD (RuneError) instead.
(Now I understand what you meant by [?].)

It looks like fossil doesn't check aggressively enough
to find bad UTF before using the name.  We should fix
this, but until then, you can use the program below,
fixbadutf, to rename the troublesome files.

Russ

#include <u.h>
#include <libc.h>

void
usage(void)
{
	fprint(2, "usage: fixbadutf [dir]\n");
	exits("usage");
}

int
isbadutf(char *s)
{
	Rune r;
	int n;

	r = Runeerror;
	for(; *s; s+=n){
		n = chartorune(&r, s);
		if(r == Runeerror && n == 1)
			return 1;
	}
	return 0;
}

char*
mkgoodname(char *name)
{
	char *gname, *p, *s;
	int i, n;
	Rune r;

	gname = malloc(strlen(name)+20);
	if(gname == nil)
		sysfatal("out of memory");
	s = gname;
	p = name;
	for(; *p; p+=n){
		n = chartorune(&r, p);
		if(r == Runeerror && n == 1)
			*s++ = '?';
		else{
			for(i=0; i<n; i++)
				*s++ = p[i];
		}
	}
	*s = 0;
	for(i=0; i<100; i++){
		if(access(gname, AEXIST) < 0)
			return gname;
		sprint(s, ".%d", i);
	}
	fprint(2, "cannot translate %s\n", name);
	return nil;
}

void
main(int argc, char **argv)
{
	char *dir, *errors, *newname, *oldname;
	int fd, i, j, n;
	Dir *d, xd;

	ARGBEGIN{
	default:
		usage();
	}ARGEND

	if(argc > 1)
		usage();
	if(argc == 1)
		dir = argv[0];
	else
		dir = ".";
	if((fd = open(dir, OREAD)) < 0)
		sysfatal("open %s: %r", dir);

	errors = nil;
	n = dirreadall(fd, &d);
	for(i=0; i<n; i++){
		if(isbadutf(d[i].name)){
			oldname = malloc(strlen(dir)+1+strlen(d[i].name)+1);
			if(oldname == nil)
				sysfatal("out of memory");
			strcpy(oldname, dir);
			strcat(oldname, "/");
			strcat(oldname, d[i].name);
			newname = mkgoodname(d[i].name);
			if(newname == nil)
				continue;
			nulldir(&xd);
			xd.name = newname;
			print("%s => %s\n", oldname, newname);
			if(dirwstat(oldname, &xd) < 0){
				fprint(2, "rename %s to %s: %r\n", oldname, newname);
				errors = "errors";
			}
			free(oldname);
			free(newname);
		}
	}
	exits(errors);
}