9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] usb/serial control open
Date: Sun, 23 Mar 2014 14:09:58 -0400	[thread overview]
Message-ID: <ef002be39bcabdda15766b9b7581e3ac@mikro.quanstro.net> (raw)

it seems odd to me that opening the ctl file would
reset some serial parameters.  wouldn't it be better
to leave them alone?

static int
dopen(Usbfs *fs, Fid *fid, int)
{
	ulong path;
	Serialport *p;

	path = fid->qid.path & ~fs->qid;
	p = fs->aux;
	switch(path){		/* BUG: unneeded? */
	case Qdata:
		dsprint(2, "serial, opened data\n");
		break;
	case Qctl:
		dsprint(2, "serial, opened ctl\n");
		if(p->isjtag)
			return 0;
>>		serialctl(p, "l8 i1");	/* default line parameters */
		break;
	}
	return 0;
}

- erik



             reply	other threads:[~2014-03-23 18:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23 18:09 erik quanstrom [this message]
2014-03-23 18:34 ` Gorka Guardiola
2014-03-23 18:55   ` erik quanstrom
2014-03-23 19:47     ` Gorka Guardiola
2014-03-23 19:55       ` Gorka Guardiola
2014-03-23 20:32         ` erik quanstrom
2014-03-23 21:08           ` Gorka Guardiola
2014-03-24  1:49             ` erik quanstrom
2014-03-23 21:32           ` Bakul Shah
2014-03-23 21:53             ` erik quanstrom
2014-03-23 22:02               ` Bakul Shah
2014-03-24  0:32                 ` erik quanstrom
2014-03-24  0:41                   ` Bakul Shah
2014-03-23  5:04                     ` lucio
2014-03-23 19:53   ` Gorka Guardiola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef002be39bcabdda15766b9b7581e3ac@mikro.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).