From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] 9vx (is this the right list)? import issue
Date: Wed, 23 Sep 2009 00:56:59 -0400 [thread overview]
Message-ID: <f2f087cbaf9480d05dca870c68fcbf0f@brasstown.quanstro.net> (raw)
In-Reply-To: <<dd6fe68a0909222111y1af0f4a2qd30a3b4eded30b2b@mail.gmail.com>>
> I mean that the code as written is assuming that if a read or write
> errors out, it can only happen for one of two reasons:
> 1) there was an interrupt note, in which case strcmp(error, Eintr) == 0
> 2) there has been an error on the 9P connection, in which case
> strcmp(error, Eintr) != 0 and the connection will never work again.
>
> My suggestion is to enforce #2: if a non-interrupt error happens,
> mark the connection so that the kernel won't even try to use it
> again.
>
> Separately, you might investigate what error is happening that
> violates the assumption above. In 9vx, it is easy: case #1 happened
> but the error was spelled wrong.
how sure are we that 1 holds? couldn't there be other,
legitimate and transient errors? could a user-delivered
note sneak in and confuse the issue?
the problem with my solution is that it could leak tags.
i don't see this as a significant problem, but i could be
wrong. i think the connection would need to be pretty
broken for tags to be leaked.
marking connections dead also adds tracking, but in
a new place. it could have trouble if ever a transient error
happens when strcmp(error, Eintr) == 0, which can
happen in 9vx or dt.
- erik
next parent reply other threads:[~2009-09-23 4:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<dd6fe68a0909222111y1af0f4a2qd30a3b4eded30b2b@mail.gmail.com>
2009-09-23 4:56 ` erik quanstrom [this message]
2009-09-23 18:52 ` Russ Cox
2009-09-23 19:12 ` ron minnich
2009-09-23 19:25 ` erik quanstrom
2009-09-23 19:26 ` Russ Cox
2009-09-23 20:33 ` ron minnich
2009-09-23 20:35 ` ron minnich
2009-09-23 22:13 ` Russ Cox
2009-09-23 21:25 ` erik quanstrom
[not found] <<dd6fe68a0909222011u4243953dged01d77ecdc93e46@mail.gmail.com>
2009-09-23 3:17 ` erik quanstrom
2009-09-23 4:11 ` Russ Cox
[not found] <<fadaba2046122acf656140c0618e1d1e@ladd.quanstro.net>
2009-09-23 2:41 ` erik quanstrom
2009-09-23 3:11 ` Russ Cox
[not found] <<13426df10909221532t5de9f010pfeb2ca2c3b44db89@mail.gmail.com>
2009-09-23 2:36 ` erik quanstrom
[not found] <<13426df10909221420x1298139fhdeb4f0803924e5a3@mail.gmail.com>
2009-09-22 21:23 ` erik quanstrom
2009-09-22 22:32 ` ron minnich
[not found] <<df49a7370909221158u3f071cc3j125c85241c5088e6@mail.gmail.com>
2009-09-22 19:01 ` erik quanstrom
2009-09-22 19:34 ` roger peppe
2009-09-22 21:12 ` ron minnich
2009-09-22 21:20 ` ron minnich
[not found] <<13426df10909221147w665e30adt93b6121281294647@mail.gmail.com>
2009-09-22 18:51 ` erik quanstrom
2009-09-21 18:29 ron minnich
2009-09-22 5:51 ` Russ Cox
2009-09-22 17:27 ` ron minnich
2009-09-22 18:21 ` ron minnich
2009-09-22 18:35 ` roger peppe
2009-09-22 18:47 ` ron minnich
2009-09-22 18:58 ` roger peppe
2009-09-22 19:08 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f087cbaf9480d05dca870c68fcbf0f@brasstown.quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).