From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <fe369894ea709839e626f4382450ad30@plan9.bell-labs.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] bug in disk/format
From: rsc@plan9.bell-labs.com
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Mon, 27 May 2002 13:49:30 -0400
Topicbox-Message-UUID: 9d858688-eaca-11e9-9e20-41e7f4b1d025

> umm, isn't this a bug in the driver?  the man page for write(2) says,
>
> The number of characters actually written is returned.
> It should be regarded as an error if this is not the same as requested.
>
> so yes, disk/format should check for short writes, but it should fail
> with a write error if it gets one, no?

and indeed it does, now.  it also only tries to write 8k
at a time to avoid aggravating the sd53c8xx problem.

> question, if it is an error, should errstr() be set?

it won't be, because the system call didn't return -1.
not sure whether it should be.

russ