9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@coraid.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] cc lexer bug?
Date: Sun, 18 Feb 2007 17:40:37 -0500	[thread overview]
Message-ID: <ff8e5bd010649b48da41b01c3b26713e@coraid.com> (raw)
In-Reply-To: <31f9a933eb03172e356de753a5092e5a@plan9.jp>

On Sun Feb 18 17:08:00 EST 2007, JoelCSalomon@Gmail.com wrote:
> I think you mean the one on 788.  I'm far from comfortable enough with
> the code here to suggest a patch, though.  Certainly not comfortable
> enough to incorporate it into my lexer.
> 

sorry.  i was using an older version of the lexer.  line 788 is the correct
one to delete.

i read the current code like this

		[...]
	assert(first digit is '0');

	if(not octal(c))
		goto dc;

	while(is octal(c))
		GETC();
	goto ncu;		// i.e. this can't be floating point.

dc:
	/* check for floating point */
	[...]

ncu:
	/* check integer size suffixes */


      reply	other threads:[~2007-02-18 22:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-18 20:19 Joel Salomon
2007-02-18 21:22 ` erik quanstrom
2007-02-18 22:07   ` Joel Salomon
2007-02-18 22:40     ` erik quanstrom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff8e5bd010649b48da41b01c3b26713e@coraid.com \
    --to=quanstro@coraid.com \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).