From: "EBo" <ebo@sandien.com>
To: "Fans of the OS Plan 9 from Bell Labs" <9fans@9fans.net>
Subject: Re: [9fans] compiler warnings for libavl/avl.c
Date: Tue, 2 Mar 2010 10:40:27 -0700 [thread overview]
Message-ID: <twig.1267551627.47659@swcp.com> (raw)
In-Reply-To: <7dfd70b01002260716p2bfbec09rfb305f284d9a1433@mail.gmail.com>
> > The following two subroutines are defined and not used anywhere. Should they
> > redefined as void or possibly removed?
>
> it's perfectly reasonable to leave code in for testing purposes
> that never gets called.
Agreed. Should the declarations be changed then to void instead of static
void so that it does not give warnings? I've worked on some projects where
the leads where very pedantic about cleaning up all warnings and was wondering
what the consensus amongst the plan 9 crowd.
> > -int errno;
> > +#include <errno.h>
> >
> > should the base source include this patch?
>
> what's the advantage? the current p9p system
> has worked for a long time. including errno.h
> seems like it has the potential to break a lot of
> stuff.
I simply noticed the patch and was wondering if there would be any advantage
to including it, so I have no idea if there is any specific advantage. I also
was not sure if this was simply a POSIX'ism or a 9'ism, and if this
could/should be cleaned up.
EBo --
next prev parent reply other threads:[~2010-03-02 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 9:43 [9fans] Has Anyone compiled 9vx on snow leopard ? prem
2010-02-26 15:16 ` Oleg Finkelshteyn
2010-03-02 17:02 ` [9fans] compiler warnings for libavl/avl.c EBo
2010-03-02 17:12 ` erik quanstrom
2010-03-02 17:40 ` EBo [this message]
2010-03-02 17:50 ` Edward E Elzey
2010-03-02 17:52 ` erik quanstrom
2010-03-02 18:41 ` EBo
2010-03-04 18:10 ` Russ Cox
2010-03-01 9:49 ` [9fans] Has Anyone compiled 9vx on snow leopard ? prem
2010-03-01 9:49 ` prem
2010-03-01 10:30 ` John Stalker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=twig.1267551627.47659@swcp.com \
--to=ebo@sandien.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).