From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 5055 invoked from network); 16 Aug 2021 23:40:53 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 16 Aug 2021 23:40:53 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 1ess; Mon Aug 16 17:27:08 -0400 2021
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 08e45ed0 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Mon, 16 Aug 2021 12:40:15 -0700 (PDT)
Message-ID: <0464831803CC1DB4840254E420F264AB@eigenstate.org>
To: 9front@9front.org
Date: Mon, 16 Aug 2021 15:40:14 -0400
From: ori@eigenstate.org
In-Reply-To: <CAHjwAuxt_wpr6CrfFSJGq0X3=ABQbS-1e-2UyAsi6HpanuHDfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: strategy WEB2.0 cloud metadata 
Subject: Re: [9front] PATCH: click-to-focus in fgui
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Silas McCroskey <inkswinc@gmail.com>:
> fgui uses libcontrol, which defaults to hover-focus. This is both
> inconsistent with the rest of the system (bar acme) and potentially
> dangerous in fgui's specific case, due to the secrets involved.
> 
> The following patch turns the libcontrol knob to switch to click-to-focus.
> 
> Not sure this merits being merged per se, but it's at least here for
> anyone else to pick up.
> 
> Attached as well since gmail will inevitably mangle it.
> 
> - sam-d
> 

My counteroffer:

--- //.git/fs/object/913fdf24972dca40feb3201fe4e32c1ab7b7c2c3/tree/sys/src/libcontrol/control.c
+++ sys/src/libcontrol/control.c
@@ -769,6 +769,7 @@
 	cs->data = chancreate(sizeof(char*), 0);
 	cs->resizeexitc = chancreate(sizeof(int), 0);
 	cs->csexitc = chancreate(sizeof(int), 0);
+	cs->clicktotype = 1;
 
 	threadcreate(resizethread, cs, 32*1024);
 	threadcreate(controlsetthread, cs, 32*1024);