From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 6220 invoked from network); 18 Dec 2023 18:59:07 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 18 Dec 2023 18:59:07 -0000
Received: from pb-smtp2.pobox.com ([64.147.108.71]) by 9front; Mon Dec 18 13:55:38 -0500 2023
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id EE4531D94C9
	for <9front@9front.org>; Mon, 18 Dec 2023 13:55:33 -0500 (EST)
	(envelope-from unobe@cpan.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id
	:to:subject:date:from:in-reply-to:mime-version:content-type
	:content-transfer-encoding; s=sasl; bh=DmyKrSRixG6kzhKitRXQ4lfX+
	FYzw/AeiNzMkHCuIew=; b=Pp5KhCfhAzldrXSsflh9VSzDzZFhfKsIhHfTTqGcC
	GBAxwTZQe3ZcF3A+wDvoFOP0iZx97JPOJS6nQzH4kLVjyVOvLJseXTJ5ZzGGwoI8
	dTKv+cYqFtxHl2kPPC8pvvJTrp0nVcpoeARzMykb1rauADZP0jlrCm+1IEpu1vak
	6s=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
	by pb-smtp2.pobox.com (Postfix) with ESMTP id E6A991D94C8
	for <9front@9front.org>; Mon, 18 Dec 2023 13:55:33 -0500 (EST)
	(envelope-from unobe@cpan.org)
Received: from strider.localdomain (unknown [24.205.13.124])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 4E2031D94C7
	for <9front@9front.org>; Mon, 18 Dec 2023 13:55:33 -0500 (EST)
	(envelope-from unobe@cpan.org)
Message-ID: <05E9D82D70FB9C02C0095FA5B87BAF99@smtp.pobox.com>
To: 9front@9front.org
Date: Mon, 18 Dec 2023 10:55:31 -0800
From: unobe@cpan.org
In-Reply-To: <9B894E6543CF0EDCADBB82B46A9C2129@felloff.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID:
 05B2577C-9DD7-11EE-9AF4-25B3960A682E-09620299!pb-smtp2.pobox.com
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: immutable virtualized browser realtime framework 
Subject: Re: [9front] [PATCH 2/6] cifsd: clarify SMBv1 is supported, not SMB 2/3.
Reply-To: 9front@9front.org
Precedence: bulk

Quoth cinap_lenrek@felloff.net:
> ok, applied.
> 
> i removed the following tho:
> 
> +	logit("processing [%.2x] command", cmd);
> 
> this is very dangerous and will just fill up your dump with
> pointless log messages.
> 
> if you want to debug, pass the -d flag (it already logs the
> commands in that case).

Thanks, cinap.  I don't recall at this point, but I think I had added
the logit() at the beginning of the sub because the command that was
problematic.  I do not think it was greater than nelems(optab) and yet
wasn't defined, so the 'if' condition would die.  There are now more
added commands, so maybe that won't even be an issue going forward.