From: Romano <unobe@cpan.org>
To: 9front@9front.org
Subject: [9front] [patch] nusb/ether -t rndis
Date: Thu, 01 Apr 2021 03:46:25 -0700 [thread overview]
Message-ID: <062010C4AA52C2737498BB5D886EFB3D@smtp.pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
The attached patch fixes ethernet tethering to work with a PinePhone.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=64e049102d3de3e61409cb6019403a9e689dfda6
mentions that the typical RNDIS is a variant of CDC ACM with CSP
0xff0202, so I added that and also noted that the existing value works
with Nexus 5 (as mentioned in the original commit).
I also updated the man page for nusb to fix a typo and to enumerate
the current list of supported types, and updated sys/src/9/boot/nusbrc
to automatically detect when an RNDIS device is connected.
[-- Attachment #2: Type: text/plain, Size: 1534 bytes --]
diff -r a62bc34fa4fa sys/man/4/nusb
--- a/sys/man/4/nusb Wed Mar 31 17:50:25 2021 +0200
+++ b/sys/man/4/nusb Thu Apr 01 10:14:27 2021 -0700
@@ -60,7 +60,7 @@
.I usbd
take the decimal usb
.I devid
-of the device they should handle as ther last argument. A
+of the device they should handle as their last argument. A
driver's instance handles only one device at a time.
.PP
Drivers that provide file systems make them available as shares under
@@ -181,6 +181,9 @@
such as
.BR rndis ,
.BR smsc ,
+.BR url ,
+.BR lan78xx ,
+.BR aue ,
.BR a88772
or
.BR a88178
diff -r a62bc34fa4fa sys/src/9/boot/nusbrc
--- a/sys/src/9/boot/nusbrc Wed Mar 31 17:50:25 2021 +0200
+++ b/sys/src/9/boot/nusbrc Thu Apr 01 10:14:27 2021 -0700
@@ -34,8 +34,11 @@
case *03
nusb/kb $id
case *02
- # CDC ethernet
- nusb/ether $etherargs $id
+ # RNDIS, otherwise CDC ethernet
+ if(~ $4 ff0202)
+ nusb/ether -t rndis $etherargs $id
+ if not
+ nusb/ether $etherargs $id
case *08
if(nusb/disk $id) @{
rfork ne
diff -r a62bc34fa4fa sys/src/cmd/nusb/ether/rndis.c
--- a/sys/src/cmd/nusb/ether/rndis.c Wed Mar 31 17:50:25 2021 +0200
+++ b/sys/src/cmd/nusb/ether/rndis.c Thu Apr 01 10:14:27 2021 -0700
@@ -118,7 +118,8 @@
for(i = 0; i < nelem(d->usb->ep); i++){
if((ep = d->usb->ep[i]) == nil)
continue;
- if(ep->iface->csp == 0x000301e0)
+ // ff0202 is canonical CSP per Linux kernel; 301e0 used by Nexus 5
+ if(ep->iface->csp == 0xff0202 || ep->iface->csp == 0x000301e0)
r = 1;
}
if(!r){
next reply other threads:[~2021-04-01 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 10:46 Romano [this message]
2021-04-01 10:56 ` Sigrid Solveig Haflínudóttir
2021-04-01 12:17 ` Maurizio Boriani
2021-04-01 12:24 ` Sigrid Solveig Haflínudóttir
2021-04-01 15:38 ` Maurizio Boriani
2021-04-01 18:53 ` Romano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=062010C4AA52C2737498BB5D886EFB3D@smtp.pobox.com \
--to=unobe@cpan.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).