Re: [9front] git/fetch: be more robust

[cinap_lenrek@felloff.net]

so this is like a race condition?

depending how fast the reader is able to process the message?

the other side of the pipeline is reading the hash and then fails to locate
it in git/fs because it has not been indexed yet when it reads too fast?

is this just a theory or is there proof that the problem is
well understood?

 		if(hparse(&want[nref], sp[0]) == -1)
 			sysfatal("invalid hash %s", sp[0]);
-		if (resolveremote(&have[nref], sp[1]) == -1)
+		if (resolveremote(&have[nref], ref[nref]) == -1)
 			memset(&have[nref], 0, sizeof(have[nref]));
-		print("remote %s %H local %H\n", sp[1], want[nref], have[nref]);
 		nref++;


wouldnt it be better to just estrdup() at the print(), then it seems
cleaner and makes the diff smaller... like:

		if (resolveremote(&have[nref], sp[1]) == -1)
 			memset(&have[nref], 0, sizeof(have[nref]));
-		print("remote %s %H local %H\n", sp[1], want[nref], have[nref]);
+		ref[nref] = estrdup(sp[1]);
		nref++

--
cinap