[9front] Patch cc to create .$O files with DMTMP

[9front] Patch cc to create .$O files with DMTMP

[Jacob Moody]

Hello,

I often have times where I find I have left build artifacts around the system from forgetting
to run mk clean. I thought it might be nice for the compiler to create the files with DMTMP
to prevent them from getting added to fs dumps.


Thanks,
moody

--- //.git/fs/object/6ae0cd0d48a1b852f4a00c09aa8056e9062b1cf1/tree/sys/src/cmd/cc/lex.c
+++ sys/src/cmd/cc/lex.c
@@ -229,7 +229,7 @@
 			dup(2, 1);
 		}
 	} else {
-		c = mycreat(outfile, 0664);
+		c = mycreat(outfile, 0664 | DMTMP);
 		if(c < 0) {
 			diag(Z, "cannot open %s - %r", outfile);
 			outfile = 0;

Re: [9front] Patch cc to create .$O files with DMTMP

[ori]

Quoth Jacob Moody <moody@mail.posixcafe.org>:
> Hello,
> 
> I often have times where I find I have left build artifacts around the system from forgetting
> to run mk clean. I thought it might be nice for the compiler to create the files with DMTMP
> to prevent them from getting added to fs dumps.
> 
> 
> Thanks,
> moody
> 
> --- //.git/fs/object/6ae0cd0d48a1b852f4a00c09aa8056e9062b1cf1/tree/sys/src/cmd/cc/lex.c
> +++ sys/src/cmd/cc/lex.c
> @@ -229,7 +229,7 @@
>  			dup(2, 1);
>  		}
>  	} else {
> -		c = mycreat(outfile, 0664);
> +		c = mycreat(outfile, 0664 | DMTMP);
>  		if(c < 0) {
>  			diag(Z, "cannot open %s - %r", outfile);
>  			outfile = 0;
> 

Makes sense to me -- easy to regenerate files
that change a lot probably shouldn't go into
the dump by default.

will commit soon.

Re: [9front] Patch cc to create .$O files with DMTMP

[Anthony Martin]

ori@eigenstate.org once said:
> Quoth Jacob Moody <moody@mail.posixcafe.org>:
> > I often have times where I find I have left build artifacts around the system from forgetting
> > to run mk clean. I thought it might be nice for the compiler to create the files with DMTMP
> > to prevent them from getting added to fs dumps.
> >
> > [...]
>
> Makes sense to me -- easy to regenerate files
> that change a lot probably shouldn't go into
> the dump by default.
>
> will commit soon.

I don't think this is a good idea as a default.
Why do intermediate object files deserve special
treatment? Are there any other programs that
create +t files automatically? If you're worried
about the size of the dump, get a bigger disk.

Cheers,
  Anthony

Re: [9front] Patch cc to create .$O files with DMTMP

[kvik]

> Why do intermediate object files deserve special
> treatment?

When was the last time you went to pick up a
$O file from the dump?

Re: [9front] Patch cc to create .$O files with DMTMP

[Jacob Moody]

On 6/8/21 6:55 PM, Anthony Martin wrote:
> I don't think this is a good idea as a default.
> Why do intermediate object files deserve special
> treatment? Are there any other programs that
> create +t files automatically?

Most programs that need intermediary/temporary

files stuff it in /tmp, which is +t by default.

I find that enough of a precedent that "temporary" files

should not be dumped.


Thanks,
moody