Re: [9front] [Bug] Mail fails to send attachments

[sirjofri <sirjofri+ml-9front@sirjofri.de>]

Hello,

20.02.2021 01:49:09 ori@eigenstate.org:
> Quoth sirjofri <sirjofri+ml-9front@sirjofri.de>:
>> I noticed that marshal also handles the whole boundary stuff and
>> attachments. The output file I get in pipefrom does not contain the 
>> data
>> from the attachment.
>>
>> To verify I made this pipefrom:
>>
>> #!/bin/rc
>> echo $* > /tmp/msgargs
>> cat > /tmp/msgcontent
>>
>> Then look at these files.
>>
>> The whole thing is formatted as a multipart message, but it only 
>> contains
>> the message text, no attachments.
>>
>> I also looked at the history of the marshal code, I don't think the
>> sendmail function is bad here.
>>
>> sirjofri
>>
>
> I'd look at whether we're closing the wrong fd
> if we're passing '-S'.

I found out, it's something completely different.

The function foldername builds the path to the outgoing directory. For 
this, it uses the upasname environment variable (or the login name if 
it's not set).

However, I had my upasname set to my sender address (joel@sirjofri.de), 
so it builds the string: /mail/box/joel@sirjofri.de/outgoing, which of 
course cannot be opened (it doesn't exist!).

Therefore, openfolder does return a wrong Biobuf with a file descriptor 
-1, our tee function fails to write there and nothing works.

Removing my upasname variable confirmed this bug.

Now I just need to find a proper solution to this. Looking at the 
returned file descriptor could be one, writing not to user but login 
directory another.

If you want to follow my description in code, marshal.c:/^sendmail, 
switch() case 0:, if (rcvr != nil), switch() case 0, the foldername 
function call.

sirjofri