From: Arne Meyer <meyer.arne83@netcologne.de>
To: 9front@9front.org
Subject: Re: [9front] [patch] ethervirtio - fix multicast without a cmd queue
Date: Mon, 18 Dec 2023 08:29:34 +0100 (CET) [thread overview]
Message-ID: <1235981774.3438616.1702884574780@comcenter.netcologne.de> (raw)
In-Reply-To: <07A941FBFC8DA8FE7E43834692DFC459@felloff.net>
Yes, that is how the virtio interface works but the driver needs to supply
some multicast function even if it does nothing.
if netmulti returns early when no multicast callback is supplied, the address is not tracked.
ethermux in devether.c calls activemulti and drops all untracked multicast packages.
With this patch i get ipv6 on my virtual machine.
Maybe we should change the way netmulti works? I don't know...
> cinap_lenrek@felloff.net hat am 17.12.2023 22:08 CET geschrieben:
>
>
> I dont follow. this doesnt change the fact that we'r not
> really enabling mcast reception or not.
>
> all it does is make it FAIL silently.
>
> Are you saying that the cmd is not needed for devices that
> do not have cmd queue and always are in promisc mode so to
> speak?
>
> If thats the case, add a comment in the code why we'r
> basically doing nothing and why that is ok.
>
> --
> cinap
next prev parent reply other threads:[~2023-12-18 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 17:26 Arne Meyer
2023-12-17 21:08 ` cinap_lenrek
2023-12-18 7:29 ` Arne Meyer [this message]
2023-12-19 17:38 ` cinap_lenrek
2023-12-19 19:41 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235981774.3438616.1702884574780@comcenter.netcologne.de \
--to=meyer.arne83@netcologne.de \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).