From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
	version=3.4.4
Received: (qmail 22961 invoked from network); 18 Dec 2023 16:12:09 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 18 Dec 2023 16:12:09 -0000
Received: from cc-smtpout3.netcologne.de ([89.1.8.213]) by 9front; Mon Dec 18 02:29:39 -0500 2023
Received: from cc-app3.netcologne.de (cc-app3.netcologne.de [89.1.9.192])
	by cc-smtpout3.netcologne.de (Postfix) with ESMTP id EA9EF124D8
	for <9front@9front.org>; Mon, 18 Dec 2023 08:29:34 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de;
	s=nc1116a; t=1702884574;
	bh=dg+5cYMJn9DoPeFW3RzQmZiIse1lOCdNaZL4bghx7Ec=;
	h=Date:From:To:Message-ID:In-Reply-To:References:Subject:From;
	b=LbvwMzjxs6XhaLJdhUnDqs5PvRFa/fZJOob2wO6nAMAP23YNpslVZ0uKJNe7NQUgQ
	 CCdhV0A+AfLdF701UJQZwq0YP51DAD1giBYR2AEZoSqPqg/iGduzR+g7O6o3l4Oe1w
	 Bp89utEDk5d/VV7qAQOWDc/VROTb8dHyforuJ1crQ+cCBkFimrpmUimOOgDzm7APCK
	 rMKS1BCb44LXi77rUK8Q2zJO0F+k4S0v6wOnIcUGbbusMeejh7o/9UHjcs2GmtlQi2
	 nt47VT03oA/zRjgCm3RDlP66QKrTYz9EVtmeRdcY922RxW9Ami1W9gD85XxzKSstuW
	 fooNmliZ2Nsow==
Received: from cc-app3.netcologne.de (localhost [127.0.0.1])
	by cc-app3.netcologne.de (Postfix) with ESMTPA id D2BF8122BE
	for <9front@9front.org>; Mon, 18 Dec 2023 08:29:34 +0100 (CET)
Date: Mon, 18 Dec 2023 08:29:34 +0100 (CET)
From: Arne Meyer <meyer.arne83@netcologne.de>
To: 9front@9front.org
Message-ID: <1235981774.3438616.1702884574780@comcenter.netcologne.de>
In-Reply-To: <07A941FBFC8DA8FE7E43834692DFC459@felloff.net>
References: <1537051341.3430184.1702834009641@comcenter.netcologne.de>
 <07A941FBFC8DA8FE7E43834692DFC459@felloff.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev50
X-Originating-IP: 2001:4dd6:8ab4:0:5a28:3637:3b4d:3ac8
X-Originating-Client: open-xchange-appsuite
X-NetCologne-Spam: L
X-Rspamd-Queue-Id: D2BF8122BE
X-Spamd-Bar: -
X-Rspamd-Action: no action
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: virtualized webscale proxy deep-learning rich-client control 
Subject: Re: [9front] [patch] ethervirtio - fix multicast without a cmd
 queue
Reply-To: 9front@9front.org
Precedence: bulk

Yes, that is how the virtio interface works but the driver needs to supply
some multicast function even if it does nothing.

if netmulti returns early when no multicast callback is supplied, the address is not tracked. 
ethermux in devether.c calls activemulti and drops all untracked multicast packages. 

With this patch i get ipv6 on my virtual machine.

Maybe we should change the way netmulti works? I don't know...

> cinap_lenrek@felloff.net hat am 17.12.2023 22:08 CET geschrieben:
> 
>  
> I dont follow. this doesnt change the fact that we'r not
> really enabling mcast reception or not.
> 
> all it does is make it FAIL silently.
> 
> Are you saying that the cmd is not needed for devices that
> do not have cmd queue and always are in promisc mode so to
> speak?
> 
> If thats the case, add a comment in the code why we'r
> basically doing nothing and why that is ok.
> 
> --
> cinap