9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Arne Meyer <meyer.arne83@netcologne.de>
To: "9front@9front.org" <9front@9front.org>
Subject: [9front] [patch] ethervgbe: reduce console spam
Date: Fri, 2 Dec 2022 17:20:19 +0100 (CET)	[thread overview]
Message-ID: <1348272106.657707.1669998019557@comcenter.netcologne.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

Moin,

this patch turns "no Tx entry available" messages into a ifstats counter
to reduce console spam.
While here, remove tx/rx offloading from the todo list to not give people 
like me ideas.

Greetings,
Arne

[-- Attachment #2: ethervgbe.c.patch --]
[-- Type: application/octet-stream, Size: 929 bytes --]

diff e5d29a2bd91951a24fccecd958416856cecef444 uncommitted
--- a/sys/src/9/pc/ethervgbe.c
+++ b/sys/src/9/pc/ethervgbe.c
@@ -15,7 +15,6 @@
  *	- shutdown
  *	- promiscuous
  *	- report error
- *	- Rx/Tx Csum
  *	- Jumbo frames
  *
  * Philippe Anel, xigh@free.fr
@@ -312,6 +311,7 @@
 	ulong	rx;
 	ulong	tx;
 	ulong	txe;
+	ulong	txentry;
 	ulong	intr;
 };
 
@@ -467,6 +467,7 @@
 	l = 0;
 	l += snprint(p+l, READSTR-l, "tx: %uld\n", ctlr->stats.tx);
 	l += snprint(p+l, READSTR-l, "tx [errs]: %uld\n", ctlr->stats.txe);
+	l += snprint(p+l, READSTR-l, "tx [no entry]: %uld\n", ctlr->stats.txentry);
 	l += snprint(p+l, READSTR-l, "rx: %uld\n", ctlr->stats.rx);
 	l += snprint(p+l, READSTR-l, "intr: %uld\n", ctlr->stats.intr);
 	snprint(p+l, READSTR-l, "\n");
@@ -803,7 +804,7 @@
 		wiob(ctlr, TxCsrS, TxCsr_Wakeup);
 
 	if(count == 0)
-		print("vgbe: transmit: no Tx entry available\n");
+		ctlr->stats.txentry++;
 }
 
 static void

             reply	other threads:[~2022-12-02 16:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 16:20 Arne Meyer [this message]
2022-12-16 18:18 ` [9front] " Arne Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348272106.657707.1669998019557@comcenter.netcologne.de \
    --to=meyer.arne83@netcologne.de \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).