From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 5370 invoked from network); 25 Feb 2021 02:25:37 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 25 Feb 2021 02:25:37 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 1ess; Wed Feb 24 21:21:27 -0500 2021
Received: from abbatoir.fios-router.home (pool-108-41-92-79.nycmny.fios.verizon.net [108.41.92.79])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 4fa1e72b (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Wed, 24 Feb 2021 18:21:15 -0800 (PST)
Message-ID: <15F8DE7C4A612A93BF917BA8798997A1@eigenstate.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
To: 9front@9front.org
Date: Wed, 24 Feb 2021 18:21:13 -0800
From: ori@eigenstate.org
In-Reply-To: <B7D5933418BF8E107C9CDF7AEBE64625@eigenstate.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: self-healing HTTP information GPU-based service 
Subject: Re: [9front] [Patch] APE changes (2019 Lufia patches)
Reply-To: 9front@9front.org
Precedence: bulk

Quoth ori@eigenstate.org:
> Quoth bsdsm@sdf.org:
> > Hello,
> > 
> > This patch is a pared down version of the changes that Lufia made back in
> > 2019; the essential changes from 'add funcs and types to APE' and all of
> > 'add #include_next directive'. An unmodified diff of the former pull
> > request can be found here[1] for comparison.
> > 
> > This has only been tested on an amd64 build. Works cleanly with tree as of
> > Feb 20, 2021 changes.
> > 
> > 
> > [1]: https://patch-diff.githubusercontent.com/raw/lufia/plan9/pull/5.diff
> > 
> > 
> > 
> > diff -r bfe93397b157 386/include/ape/_apetypes.h
> > --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> > +++ b/386/include/ape/_apetypes.h	Fri Feb 12 10:59:32 2021 -0700
> > @@ -0,0 +1,7 @@
> > +#if !defined(__BYTE_ORDER) && defined(__LITTLE_ENDIAN)
> > +#define	__BYTE_ORDER	__LITTLE_ENDIAN
> > +#endif
> > +
> > +#if !defined(BYTE_ORDER) && defined(LITTLE_ENDIAN)
> > +#define	BYTE_ORDER	LITTLE_ENDIAN
> > +#endif
> > diff -r bfe93397b157 amd64/include/ape/_apetypes.h
> > --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> > +++ b/amd64/include/ape/_apetypes.h	Fri Feb 12 10:59:32 2021 -0700
> > @@ -0,0 +1,11 @@
> > +#ifndef _BITS64
> > +#define _BITS64
> > +#endif
> > +
> > +#if !defined(__BYTE_ORDER) && defined(__LITTLE_ENDIAN)
> > +#define	__BYTE_ORDER	__LITTLE_ENDIAN
> > +#endif
> > +
> > +#if !defined(BYTE_ORDER) && defined(LITTLE_ENDIAN)
> > +#define	BYTE_ORDER	LITTLE_ENDIAN
> > +#endif
> 
> We'd need these for all the other archs that we
> support, otherwise ape will fail to build on
> anything other than 386 and amd64.
> 
> > +#endif
> > diff -r bfe93397b157 sys/include/ape/pthread.h
> 
> Would you be willing to split the pthread changes
> out? it's a lot of tricky code, and it's rather
> hard to review.
> 
> Same for the cpp include_next, which I'd rather
> not commit if we can get away with it (ie, what
> software is relying on that nonstandard extension,
> and is it a big change to fix the software, and
> maybe even upstream the change?)
> 

And, again -- can you let me know what programs this
enables, and whether they've been tested with this
patch on 9front?