9front - general discussion about 9front
 help / color / mirror / Atom feed
From: qwx@sciops.net
To: 9front@9front.org
Subject: [9front] vncv(1) 16bit colors regression
Date: Sun, 08 May 2022 18:55:17 +0200	[thread overview]
Message-ID: <16184790319BFD4766A7758780EFAF3D@wopr.sciops.net> (raw)

Hello,

Commit 90a08cf1fda8eaf4afe98f74a7572fb36b7ef369 from a while ago broke
16bit color drawing in vncv, connecting to a unix: red and blue
channels are swapped.  Unix uses Xvfb with a 1280x1024x16 screen +
x11vnc; 9front screen is XRGB32.

	; vncv -v t490sw
	server version: RFB 003.008

	auth type 2
	32 bpp, 32 depth, 0x68081828 chan, 1 truecolor, 0 bigendian


Specifically: /sys/src/cmd/vnc/color.c:143,146

	if(bpp == 32 && v->Pixfmt.bpp == 16){
		cvtpixels = cvt16to32;
		goto Done;
	}


Removing this fixes it.  It was necessary for the AMT kvm stuff, but I
don't know much about that.

What do you think?

Thanks,
qwx

                 reply	other threads:[~2022-05-08 16:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16184790319BFD4766A7758780EFAF3D@wopr.sciops.net \
    --to=qwx@sciops.net \
    --cc=9front@9front.org \
    --subject='Re: [9front] vncv(1) 16bit colors regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).