* [PATCH] Tiny rio bugfix
@ 2020-03-06 12:50 mike
2020-03-07 19:42 ` [9front] " cinap_lenrek
0 siblings, 1 reply; 2+ messages in thread
From: mike @ 2020-03-06 12:50 UTC (permalink / raw)
To: 9front
Hi
Some-time lurker, first-time poster here.
I was running a second instance of rio inside a rio window and
suddenly weird things started happening. The second instance started
imposing arbitrary limits on the size of its windows and refused to
resize some of its windows when its own window was resized.
Turns out this happens if rio's screen is 3 times as high as wide
because of a tiny mistake in its goodrect function.
Did nobody ever notice this or did it not get fixed because someone
thought it was funny to have a BIG*Dx where it doesn't belong?
diff -c /sys/src/cmd/rio/wctl.c rio/wctl.c
/sys/src/cmd/rio/wctl.c:93,99 - rio/wctl.c:93,99
/* reasonable sizes only please */
if(Dx(r) > BIG*Dx(screen->r))
return 0;
- if(Dy(r) > BIG*Dx(screen->r))
+ if(Dy(r) > BIG*Dy(screen->r))
return 0;
if(Dx(r) < 100 || Dy(r) < 3*font->height)
return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [9front] [PATCH] Tiny rio bugfix
2020-03-06 12:50 [PATCH] Tiny rio bugfix mike
@ 2020-03-07 19:42 ` cinap_lenrek
0 siblings, 0 replies; 2+ messages in thread
From: cinap_lenrek @ 2020-03-07 19:42 UTC (permalink / raw)
To: 9front
applied! many thanks!
--
cinap
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-07 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 12:50 [PATCH] Tiny rio bugfix mike
2020-03-07 19:42 ` [9front] " cinap_lenrek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).