From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 6051 invoked from network); 13 Aug 2021 20:09:52 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 13 Aug 2021 20:09:52 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 1ess; Fri Aug 13 15:18:17 -0400 2021
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id b89f91e8 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Fri, 13 Aug 2021 12:11:20 -0700 (PDT)
Message-ID: <17099125BD07923362992C9E63224B89@eigenstate.org>
To: 9front@9front.org
Date: Fri, 13 Aug 2021 15:11:18 -0400
From: ori@eigenstate.org
In-Reply-To: <20210812201155.4d837b73@spruce.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: lossless SVG CMS framework 
Subject: Re: [9front] exportfs: fix debug logging
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Amavect <amavect@gmail.com>:
> All,
> 
> Exportfs -d might not be able to create the debug file without
> permission. Instead of letting execution continue, patch 1 makes it
> fail.
> Patch 2 replaces the DFD macro with an int dfd, simplifying code by 3
> lines. Depends on patch 1.
> 
> Thanks,
> Amavect
> 

Second patch looks ok. First patch -- do we want to fail?
Also, why not get rid of the debug fd entirely, and either
syslog() or fprint(2, ...)?