From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 6426 invoked from network); 21 Jun 2021 19:59:37 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 21 Jun 2021 19:59:37 -0000
Received: from outgoing.selfhost.de ([82.98.82.6]) by 1ess; Mon Jun 21 13:53:53 -0400 2021
Received: (qmail 9302 invoked from network); 21 Jun 2021 17:53:33 -0000
Received: from unknown (HELO mx03.bss-wf.de) (postmaster@emdtgvmf.mail.selfhost.de@84.190.147.108)
  by mailout.selfhost.de with ESMTPA; 21 Jun 2021 17:53:33 -0000
Received: by mx03.bss-wf.de (Postfix, from userid 1000)
	id CE7503DD8E; Mon, 21 Jun 2021 19:53:32 +0200 (CEST)
Received: from tnbW.pala (95.81.6.19.dynamic-pppoe.dt.ipv4.wtnet.de [95.81.6.19])
	by mx03.bss-wf.de (Postfix) with ESMTPSA id 940C23DD78
	for <9front@9front.org>; Mon, 21 Jun 2021 19:53:31 +0200 (CEST)
Message-ID: <17D4B7589780B6A5C8E1B53851F04C46@bss-wf.de>
To: 9front@9front.org
Date: Mon, 21 Jun 2021 19:53:28 +0200
From: theinicke@bss-wf.de
In-Reply-To: <YNBLzJoLBatVq6U6@alice>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: realtime high-performance injection solution 
Subject: Re: [9front] commit 1a09421f7db897e1d2e2a9210f79ca4389362c3a
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Anthony Martin <ality@pbrane.org>:
> > kencc: clarify warning for unused assignments
> >
> > [...]
> >
> > - warn(Z, "set and not used: %B", bit);
> > + warn(Z, "assignment not used: %B", bit);
> 
> What is unclear about "set and not used"?
> 
> This looks to me like change for change's sake.
> Now it's even more tedious to compare the various
> compiler forks, the symmetry with "used and not
> set" is gone, and the reference to this specific
> warning in /sys/doc/comp.ms is stale.
> 
> For what gain?
> 
>   Anthony

I totally agree with what Anthony wrote;
also in addition to all of this the change is half-assed:

Just looking at the diff one can see that there is
still the line with the typo "set an not used".

s/set an not used/set and not used/ would have been a
better substitution!

--
Tobias Heinicke