From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30090 invoked from network); 1 Jan 2021 17:46:23 -0000 Received: from ewsd.inri.net (107.191.116.128) by inbox.vuxu.org with ESMTPUTF8; 1 Jan 2021 17:46:23 -0000 Received: from mimir.eigenstate.org ([206.124.132.107]) by ewsd; Fri Jan 1 12:42:18 -0500 2021 Received: from abbatoir.fios-router.home (pool-74-101-2-6.nycmny.fios.verizon.net [74.101.2.6]) by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 802be3a7 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO) for <9front@9front.org>; Fri, 1 Jan 2021 09:42:09 -0800 (PST) Message-ID: <18544CC779308C2AA34DBCFF8C5ADF50@eigenstate.org> To: 9front@9front.org CC: 9front@9front.org Date: Fri, 01 Jan 2021 09:42:08 -0800 From: ori@eigenstate.org In-Reply-To: <3BA32B1BEC14B099376DC7279062EB92@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: TOR over ORM service singleton cloud Subject: Re: [9front] cmd/sort: fix resource leak (patch) Reply-To: 9front@9front.org Precedence: bulk Quoth Igor Boehm : > diff -r 4c6206d69abb sys/src/cmd/sort.c > --- a /sys/src/cmd/sort.c Mon Dec 28 21:21:22 2020 +0100 > +++ b/sys/src/cmd/sort.c Tue Dec 29 15:11:29 2020 +0100 > @@ -209,6 +209,7 @@ > free(ol); > ol = l; > } > + free(ol); > return; > } > > Am I wrong in thinking that we should also be freeing ol->key?