From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pf0-f182.google.com ([209.85.192.182]) by ur; Fri Jun  2 00:14:21 EDT 2017
Received: by mail-pf0-f182.google.com with SMTP id e193so45389566pfh.0
        for <9front@9front.org>; Thu, 01 Jun 2017 21:14:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=from:content-transfer-encoding:subject:message-id:date:to
         :mime-version;
        bh=YDW4DwBYEzg/iZ3LkiuhgeuQs6Nz26YYOEVA3nFizKg=;
        b=iztePNX7Rn6NEgnvWIHN8y0VYrm8pPyc16/j5CQKnBKPU4YGzv0k1N7Jm9IDwe5uvW
         x8PIjSjN7csDbl3gYqj+H67o4BmmAAKBee4cd/tOlgg+lqK0mfj0p2Tj7oVizfW8R6zM
         G5V3QZsqHZ4lNV9DZX8FMextfqKUaQpP95CrGN2w5uf3hEyuShAc273Ep885tIcBagHg
         iWj7aZ5Ckc9BONmb/QuiQeLWLfj1RbNw2SmIR1T0TQ4ehVp+jmZbF3fGPJCvXOjYSD0k
         G8EcdpnrDNhzR91H8sQQP/+DSHrLPwIkrKwGqAgI3DQHskPjIKkm9AW6vUhZn71VA/G8
         ahrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:content-transfer-encoding:subject
         :message-id:date:to:mime-version;
        bh=YDW4DwBYEzg/iZ3LkiuhgeuQs6Nz26YYOEVA3nFizKg=;
        b=OQG+kf/DJvBXc8pXANeG79xgrccwLybd5SjfRjkXZ7K0XwAZcSFi7FloVBgKNz66Z0
         KHHYlMC1U2LND4cuVbbWWXr5zoa6rJN9RYabfgYbxt4hsIsU/Ih1Mnc1vZvDV+Jamubt
         XyanbkFw4it1IAfK32TnyMEp7A93r+W1/C7IvDkb8w5bCi2/mi3urXafVqhA1eqz7+o4
         r3kETRYS5hET+BhlZZ6/fu0YKe1AQA20RXUQGY9ZnLuOLPj3C4c0UlL0Fc8d+8WA9Ecj
         T5BlwH9VFA+eQiNSIsZEzC1Gz3+qyI47IZYiA9KnbE/41RamVukWDhgCaHJzG4enpasx
         YEdw==
X-Gm-Message-State: AODbwcCGYYO3yJhNaTYy48XhbrOWxx3lkyC0vvVUX2HBvkbQ69e3E4sj
	BZ1TsCUYMthIBRq3kAI=
X-Received: by 10.99.136.195 with SMTP id l186mr1719133pgd.77.1496376858016;
        Thu, 01 Jun 2017 21:14:18 -0700 (PDT)
Return-Path: <karisawa@gmail.com>
Received: from [192.168.0.249] (115-36-36-193.chubu1.commufa.jp. [115.36.36.193])
        by smtp.gmail.com with ESMTPSA id u9sm37285898pgn.55.2017.06.01.21.14.16
        for <9front@9front.org>
        (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Thu, 01 Jun 2017 21:14:17 -0700 (PDT)
From: arisawa <karisawa@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: /sys/src/cmd/awk/maketab.c
Message-Id: <18572083-C7AA-422A-A995-15917DD0D103@gmail.com>
Date: Fri, 2 Jun 2017 13:14:14 +0900
To: 9front@9front.org
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
X-Mailer: Apple Mail (2.2104)
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: hypervisor template-aware database 

Hello,

In porting awk to plan9port, maketab.c failed with "Segmentation fault".
Isn=E2=80=99t it better to fix the code as follows:

 {
 	struct xx *p;
-	int i, tok;
+	int i, n, tok;
 	Biobuf *fp;
 	char *buf, *toks[3];
=20
@@ -133,8 +133,8 @@
 	i =3D 0;
 	while ((buf =3D Brdline(fp, '\n')) !=3D nil) {
 		buf[Blinelen(fp)-1] =3D '\0';
-		tokenize(buf, toks, 3);
-		if (toks[0] =3D=3D nil || strcmp("#define", toks[0]) !=3D =
0)	/* not a valid #define */
+		n =3D tokenize(buf, toks, 3);
+		if (n =3D=3D 0 || strcmp("#define", toks[0]) !=3D 0)	=
/* not a valid #define */
 			continue;
 		tok =3D strtol(toks[2], nil, 10);
 		if (tok < FIRSTTOKEN || tok > LASTTOKEN) {


Kenji Arisawa