From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28394 invoked from network); 2 Oct 2022 18:58:27 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 2 Oct 2022 18:58:27 -0000 Received: from cc-smtpout1.netcologne.de ([89.1.8.211]) by 9front; Sun Oct 2 14:56:44 -0400 2022 Received: from cc-app1.netcologne.de (cc-app1.netcologne.de [89.1.9.190]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 43B8012923 for <9front@9front.org>; Sun, 2 Oct 2022 20:56:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1664736999; bh=KNoByvVR+Gac7liTXqSkORgiVIv/ZkMl4bqZ17bpNFg=; h=Date:From:To:Message-ID:In-Reply-To:References:Subject:From; b=MP6CZl7N68ta7iRVT9Y2mTO3M1QgA9b80jxwHUQOEzMWmNGbwIsyQq6BVda/92nSB Zh93ZUZvbrmk7Z4E+8ubHoqxoXU20KDGdbRFEW94yVwDVFgGG27ITCnhYq9v0MBbYx 0edLJ66lK+JwO0rPOP6WoHp3OVdk3otVSn3ANrWPKpHE6k6OPc8p7kEGAdD5EXxTF1 T0EKKaJoAqFpjZVoIRxAgCYTvo9Nf7wuXyJ4tqGf8y0u9kCuVMok0PVBC1Z/aTXOhZ UP7rhD9MdeMR0SYdQ85IxPvf0lGGafhkxIKF2yV9QwBF/E8I0GR1Xcale0s9lqkO+i Zg0pDCS59yzhA== Received: from cc-app1.netcologne.de (localhost [127.0.0.1]) by cc-app1.netcologne.de (Postfix) with ESMTPA id BCB8A11EB2 for <9front@9front.org>; Sun, 2 Oct 2022 20:56:38 +0200 (CEST) Date: Sun, 2 Oct 2022 20:56:38 +0200 (CEST) From: Arne Meyer To: 9front@9front.org Message-ID: <1993373294.3416290.1664736998610@comcenter.netcologne.de> In-Reply-To: <63930A6D48F026FB3A6DAA769914CA81@eigenstate.org> References: <827131327.3389568.1664620465910@comcenter.netcologne.de> <63930A6D48F026FB3A6DAA769914CA81@eigenstate.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3416289_651326811.1664736998610" X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev16 X-Originating-IP: 2001:4dd1:4eee:0:337f:dfbb:d987:e463 X-Originating-Client: open-xchange-appsuite X-NetCologne-Spam: L X-Spamd-Bar: --- X-Rspamd-Queue-Id: BCB8A11EB2 List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: webscale core generator Subject: Re: [9front] [patch] cdfs handle block sizes correctly Reply-To: 9front@9front.org Precedence: bulk ------=_Part_3416289_651326811.1664736998610 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The old Readblock value is fine for data tracks, because 4 2048 byte blocks fit in the 8192 byte RPCMAX. But cdda blocks are 2352 bytes and 4 of those don't fit into 8192 bytes and stuff breaks. If I read the code correctly my change should set the number of blocks to 4 for data tracks and to 3 for everything else. I've attached the patch to this mail to preserve whitespace. > ori@eigenstate.org hat am 01.10.2022 21:20 GMT geschrieben: > > > Quoth Arne Meyer : > > The Readblock enum does not work when you try to read audio cds. 4 > > cdda blocks are lager than 8192 and the command fails (at least when > > using an usb cd drive). This sets the block count according to the > > track block size. With this and the fix for libdisk I can rip audio > > cds on my el cheapo usb dvd drive. Tested with "Midnight Oil - Blue > > Sky Mining" > > Greetings, > > Arne > > > > > > typedef struct Buf Buf; > > --- a/sys/src/cmd/cdfs/mmc.c > > +++ b/sys/src/cmd/cdfs/mmc.c > > @@ -1171,7 +1171,7 @@ > > o->track = &drive->track[trackno]; > > o->nchange = drive->nchange; > > o->omode = OREAD; > > - o->buf = bopen(mmcread, OREAD, o->track->bs, Readblock); > > + o->buf = bopen(mmcread, OREAD, o->track->bs, Maxrpc/o->track->bs); > > these changes smell funny to me; if the block size is larger than Maxrpc, we > set nblock to 0. Looking at bread in buf.c, it seems like we'd simplly end up > trying to read 0 bytes out of these large buffers. ------=_Part_3416289_651326811.1664736998610 Content-Type: application/octet-stream; name=cdfs.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=cdfs.patch X-Part-Id: 7f94c8e2b0644e43bc7b437be277efc6 ZGlmZiBlOTM4YWNjOGZmNjRhM2NiYmQ2ZWY3YmE4OGY4M2UzZjAzZWRlNjgxIHVuY29tbWl0dGVk Ci0tLSBhL3N5cy9zcmMvY21kL2NkZnMvZGF0LmgKKysrIGIvc3lzL3NyYy9jbWQvY2Rmcy9kYXQu aApAQCAtMTMzLDEwICsxMzMsMTEgQEAKIAlEVkROYmxvY2sgPSAxNiwJCS8qIERWRCBFQ0MgYmxv Y2sgaXMgMTYgc2VjdG9ycyAqLwogCUJETmJsb2NrID0gMzIsCQkvKiBCRCBFQ0MgYmxvY2sgKGBj bHVzdGVyJykgaXMgMzIgc2VjdG9ycyAqLwogCS8qCi0JICogbWFrZSBhIHNpbmdsZSB0cmFuc2Zl ciBmaXQgaW4gYSA5UCBycGMuICBpZiB3ZSBkb24ndCBkbyB0aGlzLAotCSAqIHJlbW90ZSBhY2Nl c3MgKGUuZy4sIHZpYSAvbW50L3Rlcm0vZGV2L3NkKikgZmFpbHMgbXlzdGVyaW91c2x5LgorCSAq IG51bWJlciBvZiBibG9ja3MgcmVhZC93cml0dGVuIG11c3QgZml0IGluIHRoaXMuIGlmIHdlIGRv bid0IGRvIHRoaXMsCisJICogcmVtb3RlIGFjY2VzcyAoZS5nLiwgdmlhIC9tbnQvdGVybS9kZXYv c2QqIG9yIG51c2IvZGlzaykgZmFpbHMgbXlzdGVyaW91c2x5LgorCSAqIHNlZSAvc3lzL3NyYy85 L3BvcnQvZGV2bW50LmMgTUFYUlBDLgogCSAqLwotCVJlYWRibG9jayA9IDgxOTIvQlNjZHJvbSwK KwlNYXhycGMgPSA4MTkyLAogfTsKIAogdHlwZWRlZiBzdHJ1Y3QgQnVmIEJ1ZjsKLS0tIGEvc3lz L3NyYy9jbWQvY2Rmcy9tbWMuYworKysgYi9zeXMvc3JjL2NtZC9jZGZzL21tYy5jCkBAIC0xMTcx LDcgKzExNzEsNyBAQAogCW8tPnRyYWNrID0gJmRyaXZlLT50cmFja1t0cmFja25vXTsKIAlvLT5u Y2hhbmdlID0gZHJpdmUtPm5jaGFuZ2U7CiAJby0+b21vZGUgPSBPUkVBRDsKLQlvLT5idWYgPSBi b3BlbihtbWNyZWFkLCBPUkVBRCwgby0+dHJhY2stPmJzLCBSZWFkYmxvY2spOworCW8tPmJ1ZiA9 IGJvcGVuKG1tY3JlYWQsIE9SRUFELCBvLT50cmFjay0+YnMsIE1heHJwYy9vLT50cmFjay0+YnMp OwogCW8tPmJ1Zi0+b3RyYWNrID0gbzsKIAogCWF1eC0+bnJvcGVuKys7CkBAIC0xMzk1LDcgKzEz OTUsNyBAQAogCW8tPm5jaGFuZ2UgPSBkcml2ZS0+bmNoYW5nZTsKIAlvLT5vbW9kZSA9IE9XUklU RTsKIAlvLT50cmFjayA9IHQ7Ci0Jby0+YnVmID0gYm9wZW4obW1jd3JpdGUsIE9XUklURSwgYnMs IFJlYWRibG9jayk7CisJby0+YnVmID0gYm9wZW4obW1jd3JpdGUsIE9XUklURSwgYnMsIE1heHJw Yy9icyk7CiAJby0+YnVmLT5vdHJhY2sgPSBvOwogCiAJYXV4LT5ud29wZW4rKzsK ------=_Part_3416289_651326811.1664736998610--