From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 13867 invoked from network); 6 Oct 2021 21:45:12 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 6 Oct 2021 21:45:12 -0000
Received: from mail.9lab.org ([168.119.8.41]) by 4ess; Wed Oct  6 17:34:20 -0400 2021
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9lab.org; s=20210803;
	t=1633555255;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=neozd39GexWZLQ30BKxpzcAnOaRNYqaqw+ajUthMa/Y=;
	b=TEMyWsoR1UG1y723h8gsrp50IUh1ZnAil4WotQziabn/p5hTheDF5mk+5twF+MU4Y/QwTc
	/HnlpnGP4Yw5yvcFX0wSQMYnCeZx0/I5MV354tU1/HmBsmoLzn1ux6JqzsKTM0ZfW7x8Lj
	RHGqUbXZWJjfa0qb+UlcpYlXsfwu1Ks=
Received: from ken.9lab.home (host-185-64-155-70.ecsnet.at [185.64.155.70])
	by mail.9lab.org (OpenSMTPD) with ESMTPSA id 55875a3d (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO)
	for <9front@9front.org>;
	Wed, 6 Oct 2021 23:20:55 +0200 (CEST)
Message-ID: <1A153FE20805021CC0F9A5093A688AFD@9lab.org>
To: 9front@9front.org
Date: Wed, 06 Oct 2021 23:22:33 +0200
From: igor@9lab.org
In-Reply-To: <1dc852446d8cbfbbed587804c5b3f401f2146813.camel@biobuf.link>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: pipelining persistence reduce/map layer 
Subject: Re: [9front] [PATCH] acme: don't let tag button draw over tag border.
Reply-To: 9front@9front.org
Precedence: bulk

Tested the patch and can confirm it works as advertised. Thanks for
sending it to the list.

Cheers,
Igor


Quoth james palmer <james@biobuf.link>:
> this fixes the apperance of a 2px wide gap between the edge of the tag
> button and the start of the bottom border by making the tag button 2px
> less wide rather than shrinking it's rectange after creating the image.
> 
> from this plan9port pull request:
> https://github.com/9fans/plan9port/pull/490
> 
> - james
> 
> From: james palmer <james@biobuf.link>
> Date: Wed, 06 Oct 2021 09:19:58 +0000
> Subject: [PATCH] acme: don't let tag button draw over tag border.
> 
> ---
> diff 6ebb8b9e357944cc29ae3fafc0900ee3e325ed39
> 2134a2c638e2668f45a92ec814326689cc8089c3
> --- a/sys/src/cmd/acme/acme.c	Sun Oct  3 16:58:58 2021
> +++ b/sys/src/cmd/acme/acme.c	Wed Oct  6 10:19:58 2021
> @@ -895,16 +895,14 @@
>  		freeimage(colbutton);
>  	}
>  
> -	r = Rect(0, 0, Scrollwid+2, font->height+1);
> +	r = Rect(0, 0, Scrollwid, font->height+1);
>  	button = allocimage(display, r, screen->chan, 0, DNofill);
>  	draw(button, r, tagcols[BACK], nil, r.min);
> -	r.max.x -= 2;
>  	border(button, r, 2, tagcols[BORD], ZP);
>  
>  	r = button->r;
>  	modbutton = allocimage(display, r, screen->chan, 0, DNofill);
>  	draw(modbutton, r, tagcols[BACK], nil, r.min);
> -	r.max.x -= 2;
>  	border(modbutton, r, 2, tagcols[BORD], ZP);
>  	r = insetrect(r, 2);
>  	tmp = allocimage(display, Rect(0,0,1,1), screen->chan, 1,
> DMedblue);
> 
>