Re: [9front] Kernel memory leak

[cinap_lenrek@felloff.net]

very good catch.

i think the cunique() would *ALWAYS* be required when we are going
to stuff something on the chan's umh, as otherwise we'd have a race
condition because the returned chan from domount() -> findmount()
is shared.

alternatively, we could probably get rid of Abind mode completely,
and just have cmount() do the mounthead lookup itself instead of
using new->umh.

but for now, i think the best would be to do it like this:

	switch(amode){
	case Abind:
		/* no need to maintain path - cannot dotdot an Abind */
		m = nil;
		if(!nomount)
			domount(&c, &m, nil);
+		c = cunique(c);
+		if(c->umh != nil){	//BUG
+			print("bind umh\n");
+			putmhead(c->umh);
+		}
-		putmhead(c->umh);
		c->umh = m;
		break;

can you check if this works?

--
cinap