From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 29531 invoked from network); 3 May 2023 17:56:32 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 3 May 2023 17:56:32 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Wed May  3 13:54:54 -0400 2023
Received: from stockyard (<unknown> [172.102.12.188])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id d7240a87 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Wed, 3 May 2023 10:54:52 -0700 (PDT)
Message-ID: <1C631E48FC0511FA69A0342C80D45005@eigenstate.org>
To: 9front@9front.org
Date: Wed, 03 May 2023 13:54:48 -0400
From: ori@eigenstate.org
In-Reply-To: <CS46OWSDVPK3.10AKPB8RTRU56@meagr>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed lifecycle SVG over TOR polling engine 
Subject: Re: [9front] [PATCH] Fix rune size in `acid`
Reply-To: 9front@9front.org
Precedence: bulk

Quoth grimmware <oholiab@grimmwa.re>:
> --- a/sys/src/cmd/acid/exec.c
> +++ b/sys/src/cmd/acid/exec.c
> @@ -244,6 +244,7 @@
>  	uchar cval;
>  	ushort sval;
>  	char buf[512], reg[12];
> +	int rsize;
>  
>  	r->op = OCONST;
>  	r->fmt = fmt;
> @@ -264,7 +265,6 @@
>  	case 'u':
>  	case 'o':
>  	case 'q':
> -	case 'r':
>  		r->type = TINT;
>  		ret = get2(m, addr, &sval);
>  		if (ret < 0)
> @@ -286,6 +286,7 @@
>  	case 'U':
>  	case 'O':
>  	case 'Q':
> +	case 'r':
>  		r->type = TINT;
>  		ret = get4(m, addr, &lval);
>  		if (ret < 0)
> @@ -317,12 +318,13 @@
>  		r->string = strnode(buf);
>  		break;
>  	case 'R':
> +		rsize = sizeof(Rune);

why make rsize a variable? seems like you could just directly
use sizeof(Rune).