From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 1699 invoked from network); 26 Apr 2023 03:42:21 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 26 Apr 2023 03:42:21 -0000
Received: from pb-smtp21.pobox.com ([173.228.157.53]) by 9front; Tue Apr 25 23:40:27 -0400 2023
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
	by pb-smtp21.pobox.com (Postfix) with ESMTP id B37A11E8EE7
	for <9front@9front.org>; Tue, 25 Apr 2023 23:32:24 -0400 (EDT)
	(envelope-from unobe@cpan.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id
	:to:subject:date:from:in-reply-to:mime-version:content-type
	:content-transfer-encoding; s=sasl; bh=gV7jvEQdwROU5fzq1vyRuEzcv
	7JWygC23w0i9omUaa0=; b=Zc9DYRy6S1MOcWCJ6sJ7yiratYvCcdLAUzHLuJ5WT
	NJblL9ujzDgJEcsYOZlObL5RI6mTmac78cOaKHObfJ2SyXXgEngWRBrWLuReVuQq
	HjobYJ3pqqaPlZ5lpEdvofmK2D4lmrpGtlBZ7JJGu9s/5gcz45hmIzrplSVWv3LS
	Ag=
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
	by pb-smtp21.pobox.com (Postfix) with ESMTP id AB40D1E8EE6
	for <9front@9front.org>; Tue, 25 Apr 2023 23:32:24 -0400 (EDT)
	(envelope-from unobe@cpan.org)
Received: from strider.localdomain (unknown [75.204.169.210])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 738411E8EE5
	for <9front@9front.org>; Tue, 25 Apr 2023 23:32:21 -0400 (EDT)
	(envelope-from unobe@cpan.org)
Message-ID: <1E91A12F12C601E2DE1A3099207ADE0C@smtp.pobox.com>
To: 9front@9front.org
Date: Tue, 25 Apr 2023 20:32:18 -0700
From: unobe@cpan.org
In-Reply-To: <AE892D9B051D2B522B1FA655C59ED603@wopr.sciops.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID:
 F41829BE-E3E2-11ED-9D13-B31D44D1D7AA-09620299!pb-smtp21.pobox.com
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: virtualized generic enhancement 
Subject: Re: [9front] displayport thinkpad x230 external monitor black screen
Reply-To: 9front@9front.org
Precedence: bulk

Quoth qwx@sciops.net:
> Alright, since there are no reports for breakage, I suggest that we --
> you or me, as you prefer -- make a few minor edits as mentioned, make
> a new diff and just push it.  Apologies for the delays!

No apology needed: you're the one helping me!

Of the issues you brought up, I was certain about how to fix the 'i =
1;' -> 'break;', but less certain of how to match the surrounding code
in all cases.  The for loops spacing was easy enough, and the added
space at the end of a for loop that was unneeded (i.e., hunk @@
-2319,7, +2363,7 @@).

However, the shift operators I saw have both styles even within the
same block.  In some cases there were surrounding spaces, and in
others there weren't (e.g., hunk @@-2219,46 +2300,37 @@).  I don't
want to delay the push of the patch needlessly, but also don't want to
create disturbances in the Force by not catching the ones you noticed.
So I'd prefer you to fixup as you see fit.

Sincerely,
Romano

P.S. Thanks for also pushing the /lib/dict change!