Re: [9front] bug: nusb fails to set report protocol with a stall error

[Nick Owens <mischief@offblast.org>]

On Fri, Nov 20, 2020 at 01:43:04PM -0800, Romano wrote:
> The patch to kb.c compiled fine, but the patch for joy.c didn't compile for me:
> 
> cpu% mk
> 7c -I../lib -FTVw joy.c
> joy.c:228 name not declared: iface
> mk: 7c -I../lib -FTVw joy.c  : exit status=rc 2880351: 7c 2880353: error
> 
> Just to see if it would compile I replaced "iface" with "f->dev->usb->ep[eid]->iface" and it did. Did you have iface referring to something else?

m( thats what i get for hasty copypasta. you are correct. update patch
below, uses Subclass macro to access subclass.

diff --git a/sys/src/cmd/nusb/joy/joy.c b/sys/src/cmd/nusb/joy/joy.c
--- a/sys/src/cmd/nusb/joy/joy.c
+++ b/sys/src/cmd/nusb/joy/joy.c
@@ -222,6 +222,12 @@ setproto(KDev *f, int eid)
 		proto = Reportproto;
 	}else
 		kbfatal(f, "no report");
+
+	// if a HID's subclass code is 0, it may not support setproto,
+	// and is always initialized in report mode.
+	if(Subclass(f->dev->usb->ep[eid]->iface->csp) == 0)
+		return 0;
+
 	return usbcmd(f->dev, Rh2d|Rclass|Riface, Setproto, proto, id, nil, 0);
 }
 
diff --git a/sys/src/cmd/nusb/kb/kb.c b/sys/src/cmd/nusb/kb/kb.c
--- a/sys/src/cmd/nusb/kb/kb.c
+++ b/sys/src/cmd/nusb/kb/kb.c
@@ -368,6 +368,12 @@ setproto(Hiddev *f, int eid)
 		}
 		proto = Bootproto;
 	}
+
+	// if a HID's subclass code is 0, it may not support setproto,
+	// and is always initialized in report mode.
+	if(Subclass(iface->csp) == 0)
+		return 0;
+
 	return usbcmd(f->dev, Rh2d|Rclass|Riface, Setproto, proto, iface->id, nil, 0);
 }