9front - general discussion about 9front
 help / color / mirror / Atom feed
* [9front] [PATCH] 9/pc/trap.c: Make case fallthrough
@ 2021-12-06 22:31 Christos Margiolis
  0 siblings, 0 replies; only message in thread
From: Christos Margiolis @ 2021-12-06 22:31 UTC (permalink / raw)
  To: 9front

[-- Attachment #1: Type: text/plain, Size: 71 bytes --]

There is no need to have 2 cases doing the exact same thing.

Christos

[-- Attachment #2.1: Type: text/plain, Size: 305 bytes --]

from postmaster@4ess:
The following attachment had content that we can't
prove to be harmless.  To avoid possible automatic
execution, we changed the content headers.
The original header was:

	Content-Type: text/x-diff; charset=us-ascii
	Content-Disposition: attachment; filename="9trap_fallthrough.diff"

[-- Attachment #2.2: 9trap_fallthrough.diff.suspect --]
[-- Type: application/octet-stream, Size: 414 bytes --]

diff e2a8d3493ab0fdc345b6513a53f30f2b4f36ed97 uncommitted
--- a/sys/src/9/pc/trap.c
+++ b/sys/src/9/pc/trap.c
@@ -39,14 +39,10 @@
 	for(v = 0; v < 256; v++){
 		d1 = (vaddr & 0xFFFF0000)|SEGP;
 		switch(v){
-		case VectorBPT:
-			d1 |= SEGPL(3)|SEGIG;
-			break;
-
+		case VectorBPT: /* FALLTHROUGH */
 		case VectorSYSCALL:
 			d1 |= SEGPL(3)|SEGIG;
 			break;
-
 		default:
 			d1 |= SEGPL(0)|SEGIG;
 			break;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-06 23:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 22:31 [9front] [PATCH] 9/pc/trap.c: Make case fallthrough Christos Margiolis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).