From: Michael Forney <mforney@mforney.org>
To: 9front@9front.org
Subject: [9front] [PATCH 2/3] igfx: add TypeILK, since it differs slightly from SNB
Date: Wed, 2 Mar 2022 02:26:37 -0800 [thread overview]
Message-ID: <20220302102638.14043-3-mforney@mforney.org> (raw)
In-Reply-To: <20220302102638.14043-1-mforney@mforney.org>
ILK's LVDS transcoder select field only has 1 bit, like G45.
---
sys/src/cmd/aux/vga/igfx.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/sys/src/cmd/aux/vga/igfx.c b/sys/src/cmd/aux/vga/igfx.c
index db283587b..1c9087fd8 100644
--- a/sys/src/cmd/aux/vga/igfx.c
+++ b/sys/src/cmd/aux/vga/igfx.c
@@ -23,8 +23,9 @@ enum {
enum {
TypeG45,
- TypeIVB, /* Ivy Bridge */
+ TypeILK, /* Iron Lake */
TypeSNB, /* Sandy Bridge (unfinished) */
+ TypeIVB, /* Ivy Bridge */
TypeHSW, /* Haswell */
};
@@ -255,8 +256,9 @@ snarftrans(Igfx *igfx, Trans *t, u32int o)
t->ln[0] = snarfreg(igfx, 0x70064); /* DPLinkN */
}
break;
- case TypeIVB:
+ case TypeILK:
case TypeSNB:
+ case TypeIVB:
t->dm[0] = snarfreg(igfx, o + 0x30);
t->dn[0] = snarfreg(igfx, o + 0x34);
t->dm[1] = snarfreg(igfx, o + 0x38);
@@ -295,7 +297,8 @@ snarfpipe(Igfx *igfx, int x)
if(igfx->type != TypeHSW || x != 3)
p->src = snarfreg(igfx, o + 0x0001C);
- if(igfx->type == TypeHSW) {
+ switch(igfx->type){
+ case TypeHSW:
p->dpctl = snarfreg(igfx, o + 0x400); /* PIPE_DDI_FUNC_CTL_x */
p->dpll = &igfx->dpll[0];
if(x == 3){
@@ -303,7 +306,10 @@ snarfpipe(Igfx *igfx, int x)
p->src = snarfreg(igfx, 0x6001C);
}else
p->clksel = snarfreg(igfx, 0x46140 + x*4);
- } else if(igfx->type == TypeIVB || igfx->type == TypeSNB) {
+ break;
+ case TypeILK:
+ case TypeSNB:
+ case TypeIVB:
p->fdi->txctl = snarfreg(igfx, o + 0x100);
o = 0xE0000 | x*0x1000;
@@ -324,8 +330,10 @@ snarfpipe(Igfx *igfx, int x)
p->fdi->dpll = &igfx->dpll[(igfx->dpllsel[0].v>>(x*4)) & 1];
p->dpll = nil;
- } else {
+ break;
+ case TypeG45:
p->dpll = &igfx->dpll[x & 1];
+ break;
}
/* display plane */
@@ -349,6 +357,7 @@ snarfpipe(Igfx *igfx, int x)
p->dsp->pos = snarfreg(igfx, 0x7018C + x*0x1000);
p->dsp->size = snarfreg(igfx, 0x70190 + x*0x1000);
/* wet floor */
+ case TypeILK:
case TypeSNB:
p->cur->cntr = snarfreg(igfx, 0x70080 + x*0x40);
p->cur->base = snarfreg(igfx, 0x70084 + x*0x40);
@@ -375,6 +384,7 @@ devtype(Igfx *igfx)
case 0x0152: /* 2nd/3rd Gen Core - Core-i3 */
return TypeIVB;
case 0x0046: /* Thinkpad T510 */
+ return TypeILK;
case 0x0102: /* Dell Optiplex 790 */
case 0x0126: /* Thinkpad X220 */
return TypeSNB;
@@ -461,6 +471,7 @@ snarf(Vga* vga, Ctlr* ctlr)
igfx->vgacntrl = snarfreg(igfx, 0x071400);
break;
+ case TypeILK:
case TypeSNB:
igfx->npipe = 2; /* A,B */
igfx->cdclk = 400; /* MHz */
@@ -780,6 +791,7 @@ initdpll(Igfx *igfx, int x, int freq, int port)
dpll->ctrl.v &= ~(3<<13);
dpll->ctrl.v |= (port == PortLCD ? 3 : 0) << 13;
break;
+ case TypeILK:
case TypeSNB:
case TypeIVB:
/* transcoder dpll enable */
@@ -1159,7 +1171,7 @@ init(Vga* vga, Ctlr* ctlr)
case PortLCD:
if(igfx->type == TypeHSW)
goto Badport;
- if(igfx->type == TypeG45)
+ if(igfx->type == TypeG45 || igfx->type == TypeILK)
x = (igfx->lvds.v >> 30) & 1;
else
x = (igfx->lvds.v >> 29) & 3;
@@ -1412,7 +1424,7 @@ enablepipe(Igfx *igfx, int x)
loadreg(igfx, p->fdi->rxctl);
sleep(5);
/* clear auto training bits */
- if(igfx->type == TypeSNB)
+ if(igfx->type == TypeILK || igfx->type == TypeSNB)
p->fdi->txctl.v &= ~(3<<28 | 1<<10 | 1);
else
p->fdi->txctl.v &= ~(7<<8 | 1);
@@ -1466,7 +1478,7 @@ enablepipe(Igfx *igfx, int x)
loadreg(igfx, p->fdi->rxtu[0]);
loadreg(igfx, p->fdi->rxmisc);
- if(igfx->type == TypeSNB){
+ if(igfx->type == TypeILK || igfx->type == TypeSNB){
/* unmask bit lock and symbol lock bits */
csr(igfx, p->fdi->rximr.a, 3<<8, 0);
--
2.34.1
next prev parent reply other threads:[~2022-03-02 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 10:26 [9front] [PATCH 0/3] improve igfx ironlake support Michael Forney
2022-03-02 10:26 ` [9front] [PATCH 1/3] igfx: maintain single/double-channel LVDS mode from BIOS Michael Forney
2022-03-02 10:26 ` Michael Forney [this message]
2022-03-02 10:26 ` [9front] [PATCH 3/3] igfx: fix FDI link training on ironlake Michael Forney
2022-03-02 18:33 ` [9front] [PATCH 0/3] improve igfx ironlake support cinap_lenrek
2022-03-02 19:01 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302102638.14043-3-mforney@mforney.org \
--to=mforney@mforney.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).