9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Arne Meyer <meyer.arne83@netcologne.de>
To: "9front@9front.org" <9front@9front.org>
Subject: [9front] [patch] 9/port/sdaoe: remove unfinished atapi support
Date: Wed, 29 May 2024 19:28:08 +0200 (CEST)	[thread overview]
Message-ID: <2038857066.2601941.1717003688454@comcenter.netcologne.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

sdaoe has some vestigial code that was probably meant to support atapi. this depends on code from sdscsi,
which is not reflected in the conf files for pc and pc64 but sdscsi gets pulled in by other drivers and compiles by accident.

[-- Attachment #2: sdaoe.diff --]
[-- Type: application/octet-stream, Size: 747 bytes --]

diff ded308e5762d26ed79d26d540dfba8d336f20390 uncommitted
--- a/sys/src/9/port/sdaoe.c
+++ b/sys/src/9/port/sdaoe.c
@@ -366,14 +366,7 @@
 	int r;
 
 	c = u->dev->ctlr;
-	r = 0;
 
-	if((c->feat&Datapi) && c->drivechange){
-		if(aoeconnect(u, c) == 0 && (r = scsionline(u)) > 0)
-			c->drivechange = 0;
-		return r;
-	}
-
 	if(c->drivechange){
 		if(aoeconnect(u, c) == -1)
 			return 0;
@@ -396,8 +389,6 @@
 	Ctlr *c;
 
 	c = u->dev->ctlr;
-//	if(c->feat & Datapi)
-//		return scsibio(u, lun, write, a, count, lba);
 	data = a;
 	if(write)
 		rio = devtab[c->c->type]->write;
@@ -431,8 +422,6 @@
 
 	u = r->unit;
 	c = u->dev->ctlr;
-//	if(c->feat & Datapi)
-//		return aoeriopkt(r, d);
 
 	if(r->cmd[0] == 0x35 || r->cmd[0] == 0x91){
 		qlock(c);

             reply	other threads:[~2024-05-29 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 17:28 Arne Meyer [this message]
2024-05-31 22:39 ` cinap_lenrek
2024-06-01 16:14 ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2038857066.2601941.1717003688454@comcenter.netcologne.de \
    --to=meyer.arne83@netcologne.de \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).