[9front] rc(1) pattern-matching regression

[9front] rc(1) pattern-matching regression

[qwx]

Hello,

Pattern matching with lists no longer works:

	; ls /tmp/*.c
	/tmp/npage.c
	/tmp/pagedebug.c
	/tmp/pageold.c
	/tmp/scheduler.c
	/tmp/writeimagetest.c
	; ls /tmp/^(*.c)
	ls: /tmp/*.c: '/tmp/*.c' directory entry not found
	; 9fs dump
	; bind /n/dump/2021/1002/amd64/bin/rc /bin/rc
	; rc
	; ls /tmp/^(*.c)
	/tmp/npage.c
	/tmp/pagedebug.c
	/tmp/pageold.c
	/tmp/scheduler.c
	/tmp/writeimagetest.c

Thanks,
qwx

Re: [9front] rc(1) pattern-matching regression

[cinap_lenrek]

i see whats wrong.

we have to propagate the glob attribute thru lists
as well. before it was only handled for single words
and propagated thru concatenations... but didnt
consider lists... sorry :(

theres a patch that should fix it:

http://felloff.net/usr/cinap_lenrek/globfix.diff

the intend of the change was to not having to
bruteforce check the argument list for each Xsimple()
command for globs (which might have very large
argument lists coming from from a variable or
`{}, but instead only do the globbing
evaulation when actually needed (the expression
containing a glob, which is what the parser
knows).

--
cinap

Re: [9front] rc(1) pattern-matching regression

[qwx]

On Tue Feb 15 21:42:40 +0100 2022, cinap_lenrek@felloff.net wrote:
> i see whats wrong.
> 
> we have to propagate the glob attribute thru lists
> as well. before it was only handled for single words
> and propagated thru concatenations... but didnt
> consider lists... sorry :(
> 
> theres a patch that should fix it:
> 
> http://felloff.net/usr/cinap_lenrek/globfix.diff
> 
> the intend of the change was to not having to
> bruteforce check the argument list for each Xsimple()
> command for globs (which might have very large
> argument lists coming from from a variable or
> `{}, but instead only do the globbing
> evaulation when actually needed (the expression
> containing a glob, which is what the parser
> knows).
> 
> --
> cinap

Thanks, seems to work now :)

Cheers,
qwx

Re: [9front] rc(1) pattern-matching regression

[cinap_lenrek]

ok, pushed a fix.

thank you for reporting!

--
cinap