From: ori@eigenstate.org
To: iru.muzgo@gmail.com
To: 9front@9front.org
Subject: Re: [9front] [patch] add log2 to ape
Date: Sun, 06 Dec 2020 10:49:23 -0800 [thread overview]
Message-ID: <23D0CE12F0A6885C041A6F186B0B2920@eigenstate.org> (raw)
In-Reply-To: <3e3488b7-ef5f-3fc2-bff9-611a96bf86e6@gmail.com>
Quoth Iruatã Souza <iru.muzgo@gmail.com>:
> Hi,
>
> +
> +double
> +log2(double arg)
> +{
> + return log(x)/_log2;
> +}
>
In error cases, this divides the error return
by log2. I suspect we don't want to do that.
I'd also rather name all of the constants
consistently. Maybe uppercase the initial
character, instead of giving one of them
an _ prefix.
next prev parent reply other threads:[~2020-12-06 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 16:56 Iruatã Souza
2020-12-06 18:49 ` ori [this message]
2020-12-07 10:16 ` Iruatã Souza
2020-12-07 11:34 ` Iruatã Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23D0CE12F0A6885C041A6F186B0B2920@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
--cc=iru.muzgo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).