9front - general discussion about 9front
 help / color / mirror / Atom feed
From: "Dave MacFarlane" <driusan@driusan.net>
To: 9front@9front.org
Subject: Re: [9front] libjson can print invalid json
Date: Fri, 18 Nov 2022 09:52:36 -0500	[thread overview]
Message-ID: <263B428AAAD6B50FBA408C8673B0144A@driusan.net> (raw)
In-Reply-To: <570432963688607A01A28D3D1092E22D@driusan.net>

I was curious about keys and it looks like there's also a bug
where they're not being properly escaped. Here's a diff that
fixes that as well.

cpu% git/diff .
diff 30c5296f32b87d83529d772732726891e1261c9c uncommitted
--- a/sys/src/libjson/printjson.c
+++ b/sys/src/libjson/printjson.c
@@ -7,6 +7,32 @@
 static int printobject(Fmt*, JSON*, int);
 
 static int
+printstring(Fmt *f, char *s)
+{
+	int n;
+	
+	n = fmtrune(f, '"');
+	for(; *s; s++){
+		switch(*s){
+		case '\\':	n += fmtstrcpy(f, "\\\\");	break;
+		case '\f':	n += fmtstrcpy(f, "\\f");	break;
+		case '\b':	n += fmtstrcpy(f, "\\b");	break;
+		case '\n':	n += fmtstrcpy(f, "\\n");	break;
+		case '\r':	n += fmtstrcpy(f, "\\r");	break;
+		case '\"':	n += fmtstrcpy(f, "\\\"");	break;
+		default:
+
+			if(*s < 0x20)
+				n += fmtprint(f, "\\u%04x", *s);
+			else
+				n += fmtrune(f, *s);
+		}
+	}
+	n = fmtrune(f, '"');
+	return n;
+}
+
+static int
 printarray(Fmt *f, JSON *j, int indent)
 {
 	JSONEl *jl;
@@ -41,7 +67,8 @@
 	for(jl = j->first; jl != nil; jl = jl->next){
 		for(i = 0; i < indent; i++)
 			fmtprint(f, "\t");
-		r += fmtprint(f, "\"%s\": ", jl->name);
+		r += printstring(f, jl->name);
+		r += fmtprint(f, ": ");
 		r += printjson(f, jl->val, indent);
 		r += fmtprint(f, "%s\n", jl->next != nil ? "," : "");
 	}
@@ -65,7 +92,7 @@
 		return fmtprint(f, "%f", j->n);
 		break;
 	case JSONString:
-		return fmtprint(f, "\"%s\"", j->s);
+		return printstring(f, j->s);
 		break;
 	case JSONArray:
 		return printarray(f, j, indent+1);


      reply	other threads:[~2022-11-18 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 21:52 Dave MacFarlane
2022-11-18  4:30 ` ori
2022-11-18 14:37   ` Dave MacFarlane
2022-11-18 14:52     ` Dave MacFarlane [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=263B428AAAD6B50FBA408C8673B0144A@driusan.net \
    --to=driusan@driusan.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).