9front - general discussion about 9front
 help / color / mirror / Atom feed
* [9front] upas/vf: exclude mime boundary from temporary attachment files
@ 2021-02-07 22:51 Michael Forney
  0 siblings, 0 replies; only message in thread
From: Michael Forney @ 2021-02-07 22:51 UTC (permalink / raw)
  To: 9front

validateattachment has no business with the mime boundary; it is not
part of the attachment itself.

Also, it causes the boundary to be dropped in the message output from
upas/vf, effectively dropping the following attachment (though the
content is still present after the last boundary of the wrapped first
attachment part).

Consider the following sequence of events:
1. upas/vf is run on a message containing two attachments.
2. The first attachment does not have a known extension, so is saved
   to a temporary file *including* the following mime boundary.
3. This file is opened as p->tmpbuf, which is used for subsequent
   reads until switching back to stdin.
4. The attachment fails validateattachment, so upas/vf wraps it in a
   multipart with a warning message.
5. problemchild() calls passbody(p, 0), which copies from p->tmpbuf
   until it hits the outer boundary line, which it excludes, seeks
   back one line, then returns the outer multipart.
6. problemchild() then writes its own boundary, and then copies one
   line from *stdin* to stdout, expecting the outer boundary.
   However, this boundary was already read from stdin in 2, so it ends
   up reading the first line of the subsequent part instead.

To fix this, pass 0 to passbody() in save() to exclude it from the
attachment file and make it available in stdin when expected.

diff 776cb37fd6894d9e73b252d60f386d3cfb7c876c 7316cf014f78ae5b777152f50c3ebbb7da5b82e8
--- a/sys/src/cmd/upas/vf/vf.c	Sun Feb  7 01:22:23 2021
+++ b/sys/src/cmd/upas/vf/vf.c	Sun Feb  7 14:51:05 2021
@@ -387,7 +387,7 @@
 	Bprint(&out, "From virusfilter %τ\n", thedate(&tm));
 	writeheader(p, 0);
 	bodyoff = Boffset(&out);
-	passbody(p, 1);
+	passbody(p, 0);
 	Bprint(&out, "\n");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-08  5:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-07 22:51 [9front] upas/vf: exclude mime boundary from temporary attachment files Michael Forney

9front - general discussion about 9front

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/9front

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 9front 9front/ http://inbox.vuxu.org/9front \
	public-inbox-index 9front

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git