From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 8607 invoked from network); 25 Nov 2023 01:11:32 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 25 Nov 2023 01:11:32 -0000
Received: from mail.posixcafe.org ([45.76.19.58]) by 9front; Fri Nov 24 20:09:26 -0500 2023
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posixcafe.org;
	s=20200506; t=1700874583;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jnkdVZNU1cSwntJvhlAGfYCs3yGYWSH+Y0eGr/14a7s=;
	b=Uv1TbtW9K/xNaXb+Cz8ZxgUCYJTQXYrHtUzzHRfnb44YKp8/Zfj60fIokKo6ruIp0OtYiG
	GHFAi/0HVmwBSyKMqJh7knZ1sUWuDLVS+asGWOljv6PRWXPMTPTicX+cKp9tg7g9wR3Sw0
	mLPk7AV3jyWBYOHjdiJ4I61tsrQWsSA=
Received: from [192.168.168.200] (<unknown> [207.45.82.38])
	by mail.posixcafe.org (OpenSMTPD) with ESMTPSA id c1265928 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO)
	for <9front@9front.org>;
	Fri, 24 Nov 2023 19:09:42 -0600 (CST)
Message-ID: <28743601-0618-4a3f-a39b-66a1e438f7f4@posixcafe.org>
Date: Fri, 24 Nov 2023 19:09:23 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: 9front@9front.org
References: <904397cf-6c3f-46c4-9139-7f80823ec064@invalid.invalid>
 <4eeba9d4-12f2-4938-b0b3-5a8404653282@posixcafe.org>
 <8708ecaa-0b89-430d-ad06-2fd272680660@invalid.invalid>
From: Jacob Moody <moody@posixcafe.org>
In-Reply-To: <8708ecaa-0b89-430d-ad06-2fd272680660@invalid.invalid>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: object-oriented RESTful package-based property XMPP metadata framework callback generator 
Subject: Re: [9front] [PATCH] Fix assert macro to not break on commas
Reply-To: 9front@9front.org
Precedence: bulk

On 11/24/23 18:27, Blue-Maned_Hawk wrote:
> On 11/22/23 23:20, Jacob Moody wrote:
>> On 11/22/23 17:11, Blue-Maned_Hawk wrote:
>>> This is a pair of patches that changes the assert macro to be variadic,
>>> allowing expressions with commas in them to be used without needing a
>>> spare pair of parentheses, and updates the manpage accordingly.
>>> 
>>
>> For what reason does this need changed?
> 
> To avoid (admittedly, edge) cases where a comma in the expression being 
> asserted would be incorrectly interpretted as an attempt to invoke a 
> single-argument macro with two or more arguments.

This a problem that can be avoided by just using the interface correctly.

> 
>> Is there some code you're working with expecting this?
> 
> No.
> 
>> I am inclined to prefer to keep this as is.
> 
> Why?
> 

I am generally against increasing the complexity of our macros unless
there is a good enough usecase for it, which I have not been convinced of
here.