From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 10090 invoked from network); 18 Apr 2021 01:49:49 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 18 Apr 2021 01:49:49 -0000
Received: from pb-smtp21.pobox.com ([173.228.157.53]) by 1ess; Sat Apr 17 19:44:35 -0400 2021
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
	by pb-smtp21.pobox.com (Postfix) with ESMTP id D31AC12028E
	for <9front@9front.org>; Sat, 17 Apr 2021 19:42:15 -0400 (EDT)
	(envelope-from unobe@cpan.org)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=message-id:to
	:subject:date:from:mime-version:content-type
	:content-transfer-encoding; s=sasl; bh=p6DvECijYMViNGOc0X56ZPVpC
	O0=; b=g3Pkk+HZM11FscwCQ2Aqg2AMFd0Th/vpAg8Ef5qCZGIJ6rlPNzuMDVAZu
	l8/x19P+PdXCzSu0gT5DKQe/2p0bUI+Y9wuiaC5qCe6JMNQCXPNC7mKmVtfP5VtU
	PRRqIGOLW/ZAmTQRZmIrT3BbsBQWx4Jzylyy4+6bCi5QXjEXm8=
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
	by pb-smtp21.pobox.com (Postfix) with ESMTP id CA33812028C
	for <9front@9front.org>; Sat, 17 Apr 2021 19:42:15 -0400 (EDT)
	(envelope-from unobe@cpan.org)
Received: from peregrin (unknown [47.34.135.186])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 1F93E12028A
	for <9front@9front.org>; Sat, 17 Apr 2021 19:42:13 -0400 (EDT)
	(envelope-from unobe@cpan.org)
Message-ID: <300907D4A2559E449892D14BF1AB6348@smtp.pobox.com>
To: 9front@9front.org
Date: Sat, 17 Apr 2021 16:42:11 -0700
From: unobe@cpan.org
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID:
 88CC3030-9FD6-11EB-9F61-D609E328BF65-09620299!pb-smtp21.pobox.com
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: immutable content-addressed proxy wrapper ActivityPub CSS polling backend 
Subject: [9front] patch for imap when imap fails
Reply-To: 9front@9front.org
Precedence: bulk

changeset:   8411:19f6a88ea241
branch:      mbp-2011
user:        Romano <unobe@cpan.org>
date:        Sat Apr 17 14:35:21 2021 -0700
files:       sys/src/cmd/upas/fs/imap.c
description:
When an imap fetch fails, it's helpful at times to know the underlying
cause.  This provides more details by providing the underlying error
message.


diff -r e67425888043 -r 19f6a88ea241 sys/src/cmd/upas/fs/imap.c
--- a/sys/src/cmd/upas/fs/imap.c	Sat Apr 17 14:34:04 2021 -0700
+++ b/sys/src/cmd/upas/fs/imap.c	Sat Apr 17 14:35:21 2021 -0700
@@ -865,14 +865,16 @@
 imap4fetch(Mailbox *mb, Message *m, uvlong o, ulong l)
 {
 	Imap *imap;
+	char *resp;
 
 	imap = mb->aux;
 	if(imap->flags & Fgmail)
 		l = gmaildiscount(m, o, l);
 	idprint(imap, "uid fetch %lud (flags body.peek[]<%llud.%lud>)\n", (ulong)m->imapuid, o, l);
 	imap4cmd(imap, "uid fetch %lud (flags body.peek[]<%llud.%lud>)", (ulong)m->imapuid, o, l);
-	if(!isokay(imap4resp0(imap, mb, m))){
-		eprint("imap: imap fetch failed\n");
+	resp = imap4resp0(imap, mb, m);
+	if(!isokay(resp)){
+		eprint("imap: imap fetch failed: %s\n", resp);
 		return -1;
 	}
 	return 0;