9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] [PATCH] alc ethernet driver port
Date: Tue, 6 Oct 2020 08:16:31 +0200	[thread overview]
Message-ID: <3116B28A90D70D43EA40D542624E4AA1@felloff.net> (raw)
In-Reply-To: <87lfgl13o1.fsf@factor-ts.ru>

nice! doesnt look too bad.

maybe add the constants from etheralc.h to etheralc.c directly
and get rid of the header?

otherwise, we'd need to modify the mkfile as well to track
the header dependency...

i will take another look at it on the weekend. i dont have
much time during the week now...

--
cinap


      reply	other threads:[~2020-10-06  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05  8:24 Peter Kosyh
2020-10-06  6:16 ` cinap_lenrek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3116B28A90D70D43EA40D542624E4AA1@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).