From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 27187 invoked from network); 9 Nov 2021 19:31:40 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 9 Nov 2021 19:31:40 -0000
Received: from duke.felloff.net ([216.126.196.34]) by 4ess; Tue Nov  9 14:27:41 -0500 2021
Message-ID: <316DC1762EF8EB5DC3E1756D964999CD@felloff.net>
Date: Tue, 09 Nov 2021 20:27:30 +0100
From: cinap_lenrek@felloff.net
To: 9front@9front.org
In-Reply-To: <2203D6ED28C225EDCF76C0393E1960A8@9lab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: RESTful distributed core XML over JSON standard-based pipelining solution 
Subject: Re: [9front] cmd/rc: fix leaking runq->cmdfile (patch)
Reply-To: 9front@9front.org
Precedence: bulk

nice, looks good to me on first glance.

note, we should probably add a setmalloctag(p, getcallerpc(&n));
inside emallc() to make your leak hunt easier.

--
cinap